Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document safeTxGas changes #282

Closed
rmeissner opened this issue Mar 23, 2021 · 0 comments · Fixed by #366
Closed

Document safeTxGas changes #282

rmeissner opened this issue Mar 23, 2021 · 0 comments · Fixed by #366

Comments

@rmeissner
Copy link
Member

rmeissner commented Mar 23, 2021 •
edited
Loading

We should document the changes made to the safeTxGas with #274

  • When safeTxGas == 0 && gasPrice == 0 -> Sent along all available gas and does not invalidate nonce on failure

  • When safeTxGas > 0 && gasPrice == 0 -> Sent along all available gas and invalidates nonce on failure

  • When safeTxGas > 0 && gasPrice > 0 -> Sent along specified gas (safeTxGas) and invalidates nonce on failure

  • As safeTxGas specifies the minimum required gas that should be sent along it is possible to use 1 if you trust the executor and still want to invalidate the the nonce. When using a relayer (or any other untrusted executor) it is recommended to use a proper safeTxGas that corresponds to the gas that should be sent along with the execution.
@rmeissner rmeissner added this to the contracts-safe-1.3.0 milestone Mar 23, 2021
@rmeissner rmeissner mentioned this issue Mar 24, 2021
Closed
4 tasks
@rmeissner rmeissner removed this from the contracts-safe-1.3.0 milestone Oct 25, 2021
rmeissner added a commit that referenced this issue Dec 7, 2021
@rmeissner
Closes #282
86a0997
@rmeissner rmeissner mentioned this issue Dec 7, 2021
Merged
rmeissner added a commit that referenced this issue Dec 20, 2021
@rmeissner
Closes #282 (#366)
da66b45
0xArdi pushed a commit to valory-xyz/safe-contracts that referenced this issue Sep 13, 2022
@rmeissner @0xArdi
Closes safe-global#282 (safe-global#366)
1adbfb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #282 safe-global/safe-smart-account
1 participant
@rmeissner