Use latest PMAT (mostly caching stuff) #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kongzii
commented
Oct 31, 2024
|
|
||
|
|
||
| @db_cache(max_age=timedelta(days=3)) |
There was a problem hiding this comment.
I thought that in APIs, it makes sense to observe only the first call -- no benefit in observing every call from potentially many many users on frontend. That's why the db_cache decorator is above observe decorator.
kongzii
commented
Oct 31, 2024
| @@ -56,17 +36,19 @@ def market_insights(market_id: HexAddress) -> MarketInsightsResponse: | |||
| raise fastapi.HTTPException( | |||
| status_code=404, detail=f"Market with id `{market_id}` not found." | |||
| ) | |||
| except Exception as e: | |||
| logger.error(f"Failed to fetch market for `{market_id}`: {e}") | |||
| raise fastapi.HTTPException(status_code=500) | |||
There was a problem hiding this comment.
A little simplification thanks to this -- on unhandled errors, APIs usually raise 500 instead of catching it and returning a dummy response.
gabrielfior
reviewed
Nov 5, 2024
| ) | ||
| except Exception as e: | ||
| logger.error(f"Failed to get tavily_response for market `{market_id}`: {e}") | ||
| tavily_response = None | ||
| raise fastapi.HTTPException(status_code=500) |
There was a problem hiding this comment.
Don't we want to inform the user that the market wasn't found? So probably raise a 404 (or any 4xx)?
There was a problem hiding this comment.
Yes, but that is already handled above:
These 500 codes should be raised only if there are unseemed errors/bugs.
gabrielfior
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.