Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

Show ens domain on address bar #884

Open
alfetopito opened this issue Nov 30, 2021 · 2 comments
Open

Show ens domain on address bar #884

alfetopito opened this issue Nov 30, 2021 · 2 comments
Labels
app:Explorer Explorer App Low Severity indicator for defects. It won't cause any major break-down of the system Protofire task to the protofire team

Comments

@alfetopito
Copy link
Contributor

Description

Follow up to #869, show ENS domains on address bar

Proposal

  1. When directly input in the url, load the address associated with an ENS domain and don't replace it with the address:
    https://.../address/vitalik.eth <- if it exists and it's valid
  2. When searching for and end domain, use that as the url instead of the decoded address.

An additional/optional step would be, if searching by an address that has an ens domain pointing to it (similar to what Ramiro is doing for CowSwap), we could display the address in the UI OR replace the URL with given domain:
/address/0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045 -> /address/vitalik.eth

@alfetopito alfetopito added app:Explorer Explorer App Protofire task to the protofire team Low Severity indicator for defects. It won't cause any major break-down of the system labels Nov 30, 2021
@elena-zh
Copy link

elena-zh commented Dec 7, 2021

I think, the 1st part of this issue is resolved in #888 .

The optional part is left

An additional/optional step would be, if searching by an address that has an ens domain pointing to it (similar to what Ramiro is doing for CowSwap), we could display the address in the UI OR replace the URL with given domain:
/address/0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045 -> /address/vitalik.eth

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you think it shouldn't be closed, speak now or forever hold your peace.

@stale stale bot added the wontfix Stale issue label Mar 2, 2022
@elena-zh elena-zh removed the wontfix Stale issue label Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:Explorer Explorer App Low Severity indicator for defects. It won't cause any major break-down of the system Protofire task to the protofire team
Projects
None yet
Development

No branches or pull requests

2 participants