Skip to content
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.

Contracts for the explorer are not network aware #408

Closed
anxolin opened this issue Apr 27, 2021 · 4 comments · Fixed by #934
Closed

Contracts for the explorer are not network aware #408

anxolin opened this issue Apr 27, 2021 · 4 comments · Fixed by #934
Assignees
@alfetopito @matextrem
Labels
app:Explorer Explorer App Bug Something isn't working Medium Protofire task to the protofire team

Comments

@anxolin
Copy link
Contributor

anxolin commented Apr 27, 2021

Describe the bug
The explorer has support for mainnnet, but also for rinkeby and xdai. However the footer links only point to mainnet

How to Reproduce
Steps to reproduce the behavior:

  1. Go to http://protocol-explorer.dev.gnosisdev.com/rinkeby (note the rinkeby at the end)
  2. Click on the footer link
  3. If they take you to the version in mainet or rinkeby/xdai

Screenshots
image
@anxolin anxolin added Bug Something isn't working app:Explorer Explorer App labels Apr 27, 2021
@alfetopito alfetopito self-assigned this Apr 27, 2021
@stale
Copy link

stale bot commented Nov 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you think it shouldn't be closed, speak now or forever hold your peace.

@stale stale bot added the wontfix Stale issue label Nov 25, 2021
@elena-zh elena-zh added Mobile Affects mobile only Medium and removed wontfix Stale issue Mobile Affects mobile only labels Nov 26, 2021
@elena-zh
Copy link

Still valid

@anxolin
Copy link
Contributor Author

anxolin commented Nov 26, 2021

This should be a quick fix, specially since we already do it in CowSwap. Low prio though
cc/ @alfetopito

@alfetopito alfetopito added the Protofire task to the protofire team label Nov 26, 2021
@alfetopito alfetopito mentioned this issue Nov 30, 2021
Open
9 tasks
@matextrem matextrem self-assigned this Dec 2, 2021
@anxolin
Copy link
Contributor Author

anxolin commented Dec 10, 2021

Easy to test with the fancy new network switcher :)

@matextrem matextrem mentioned this issue Jan 3, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alfetopito alfetopito

@matextrem matextrem

Labels
app:Explorer Explorer App Bug Something isn't working Medium Protofire task to the protofire team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Explorer] Make contracts URLs on footer network aware gnosis/gp-ui
4 participants
@alfetopito @anxolin @matextrem @elena-zh