Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with parcel/transformer-js #1

Closed
TheManFromEarth1 opened this issue Sep 4, 2022 · 3 comments
Closed

Error with parcel/transformer-js #1

TheManFromEarth1 opened this issue Sep 4, 2022 · 3 comments
Labels
question Further information is requested

Comments

@TheManFromEarth1
Copy link

TheManFromEarth1 commented Sep 4, 2022

Thanks for the library.

I seem to get this error with parcel. Will see what I can find

`🚨 @parcel/transformer-js: Expected ',', got 'xmlns'

../node_modules/solid-theme-provider/dist/solid-theme-provider.jsx:71:33
70 |

71 |
| ^^^^^
72 | <path d="M7.95,24.88c-1.56-.68-2.94-1.61-4.13-2.81s-2.13-2.57-2.81-4.
73 | );`

Versions:
"solid-js": "^1.4.8",
"solid-theme-provider": "^0.5.0",

@gnomical
Copy link
Owner

gnomical commented Sep 5, 2022

Thanks for the info. I just released a new version but a fix for this was not included in the update.

I don't use parcel in any of my build pipelines. If you can link me to a project that is experiencing this issue I may be able to look into it.

@gnomical
Copy link
Owner

gnomical commented Sep 5, 2022

After a bit of research it appears that parcel has regular issues of this type. It seems to not handle jsx and typescript very well (parcel-bundler/parcel#6176) and it has consistency issues loading .babelrc (solidjs/solid#884).

I would recommend switching to vite, the official way to build solidjs projects. (https://github.com/solidjs/templates)

@gnomical gnomical added bug Something isn't working question Further information is requested good first issue Good for newcomers and removed bug Something isn't working labels Sep 5, 2022
@gnomical
Copy link
Owner

gnomical commented Sep 9, 2022

Let me know if switching build tools is satisfactory. If so, I'd like to close this issue.

@gnomical gnomical removed the good first issue Good for newcomers label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants