Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mod): make remote dynamic #553

Merged
merged 5 commits into from
Mar 6, 2023
Merged

feat(mod): make remote dynamic #553

merged 5 commits into from
Mar 6, 2023

Conversation

harry-hov
Copy link
Contributor

@harry-hov harry-hov commented Mar 3, 2023 •
edited
Loading

Description

Add remote flag to gnodev mod download command.
Default: test3.gno.land:36657

Related #462

@harry-hov harry-hov requested review from moul and zivkovicmilos March 3, 2023 08:27
@harry-hov harry-hov requested a review from a team as a code owner March 3, 2023 08:27
@harry-hov harry-hov self-assigned this Mar 3, 2023
@harry-hov harry-hov force-pushed the hariom/make-remote-dynamic branch from 26fa970 to dbf5488 Compare March 3, 2023 08:52
zivkovicmilos
zivkovicmilos approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

I'd probably update the PR description to include just a bit more details on why we need the configurable remote for mod downloads, otherwise it's good to go 🚀

cmd/gnodev/mod.go Show resolved Hide resolved
cmd/gnodev/mod.go Outdated Show resolved Hide resolved
@moul moul merged commit 01fd24e into gnolang:master Mar 6, 2023
harry-hov added a commit to harry-hov/gno that referenced this pull request Mar 7, 2023
@harry-hov
feat(mod): make remote dynamic (gnolang#553)
4acf69a
@harry-hov harry-hov mentioned this pull request Mar 7, 2023
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@moul moul moul approved these changes

Assignees

@harry-hov harry-hov

Labels
None yet
Projects
🚀 The Launch [DEPRECATED]
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harry-hov @moul @zivkovicmilos