Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github-bot): refactor comment + add force skip #3311

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

aeddi
Copy link
Contributor

@aeddi aeddi commented Dec 9, 2024

This PR significantly modifies the github-bot's comment and adds a button to force the success of its CI check, even it the requirements provided in the config are not met.

Related to #3238 (comment)

Edit: I updated the comment below by running the bot on my laptop if you want to see the result (so the skip button is not working yet).

@aeddi aeddi self-assigned this Dec 9, 2024
@aeddi aeddi requested review from moul and thehowl December 9, 2024 15:51
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 9, 2024

I'm a bot that assists the Gno Core team in maintaining this repository. My role is to ensure that contributors understand and follow our guidelines, helping to streamline the development process.

The following requirements must be fulfilled before a pull request can be merged.
Some requirement checks are automated and can be verified by the CI, while others need manual verification by a staff member.

These requirements are defined in this configuration file.

Automated Checks

🟢 Maintainers must be able to edit this pull request (more info)
🔴 The pull request head branch must be up-to-date with its base (more info)

Manual Checks

No manual checks match this pull request.

Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: aeddi/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base (more info)

If

🟢 Condition met
└── 🟢 On every pull request

Then

🔴 Requirement not satisfied
└── 🔴 Head branch (aeddi:dev/aeddi/github-bot-refactor) is up to date with base (master): behind by 4 / ahead by 1

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 7.89474% with 35 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
contribs/github-bot/internal/check/check.go 0.00% 23 Missing ⚠️
contribs/github-bot/internal/check/comment.go 30.00% 7 Missing ⚠️
contribs/github-bot/internal/config/config.go 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@aeddi aeddi marked this pull request as ready for review December 9, 2024 16:20
@thehowl thehowl merged commit 8e7fb50 into gnolang:master Dec 10, 2024
110 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants