feat: add Matija's Homepage realm to examples #2916

matijamarjanovic · 2024-10-07T02:27:28Z

Summary

This pull request adds a new realm example to the Gno examples repository—Matija's Homepage. It showcases a personal homepage built on the Gno chain where users can interact by voting with GNOT tokens to change the page's color. The more tokens users send, the greater influence they have on the color scheme, providing an interactive and dynamic experience.

Key Features

Profile Section: Displays a personal profile with an image and description.
Color Voting: Users can vote for the page's color (red, green, blue) by sending GNOT tokens. RGB values are adjusted based on the amount sent.
Dynamic Updates: The homepage dynamically updates the color based on votes, showcasing real-time interaction on the Gno blockchain.
Links to GitHub and LinkedIn: Includes buttons for GitHub and LinkedIn, making it easy for users to connect.

Tools & Technologies

Utilizes Gno's native functions to handle voting and token transfers.
Provides a simple, yet effective example of how personal realms can be interactive and engaging on the Gno platform.

Why this is valuable

This example highlights the possibilities of personal realms on Gno, showing how users can create unique and interactive profiles. It’s a fun and approachable entry point for anyone new to Gno development, while also demonstrating the platform's flexibility and potential for creative expression.

…revRealm().Addr()

…m() are used

notJoon

Left some comments. please check them out. thank you

examples/gno.land/r/matijamarjanovic/config/config.gno

…ble's names are seems ambiguous. Could you update their names? like mainAddr)

… on PR - error messages are repeated (invalid arress and unauthorized). please make them as constant.)

…mment on PR - very niptick: consider change parameter name a to more concrete name.)

matijamarjanovic · 2024-10-10T14:17:32Z

Thank you for your insights @notJoon. I've fixed the issues, please let me know if I can make anything more appropriate.

Maelkum

Passerby here, feel free to ignore my comments. Was just passing by and was curious about why some things are the way they are

examples/gno.land/r/matijamarjanovic/home/config.gno

examples/gno.land/r/matijamarjanovic/home/home.gno

examples/gno.land/r/matijamarjanovic/home/config.gno

examples/gno.land/r/matijamarjanovic/home/home.gno

matijamarjanovic · 2024-10-14T13:53:10Z

Thank you for your review @Maelkum before I say anything I have to say that this is the first thing I have built in Gno and generally on gno chain. This was built by following @leohhhn's live coding session (which is on gno.land's Youtube channel) where he built his own homepage which is in the examples. This is why I chose to do some of the things I did the way I did them. I fixed couple of the things you mentioned that I thought needed fixing, the rest I will try explaining in the replies to your comments.

…orized so the logic is only in 1 place

thehowl · 2024-10-23T12:44:40Z

Putting in draft, click ready for review when it's ready for a second look.

Gno2D2 · 2024-12-09T11:55:04Z

I'm a bot that assists the Gno Core team in maintaining this repository. My role is to ensure that contributors understand and follow our guidelines, helping to streamline the development process.

The following requirements must be fulfilled before a pull request can be merged.
Some requirement checks are automated and can be verified by the CI, while others need manual verification by a staff member.

These requirements are defined in this configuration file.

Automated Checks

🟢 Maintainers must be able to edit this pull request (more info)
🟢 The pull request head branch must be up-to-date with its base (more info)

Manual Checks

The pull request description provides enough details (checked by @leohhhn)

Debug

Automated Checks
Maintainers must be able to edit this pull request (more info)
If
🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: matijamarjanovic/gno)
Then
🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request
The pull request head branch must be up-to-date with its base (more info)
If
🟢 Condition met
└── 🟢 On every pull request
Then
🟢 Requirement satisfied
└── 🟢 Head branch (matijamarjanovic:master) is up to date with base (master): behind by 0 / ahead by 43
Manual Checks
The pull request description provides enough details
If
🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
Can be checked by

team core-contributors

- reorganize the home.gno so it doesn't use html anymore but mark down lib by @thanhgoc541 - change logic to vote for theme of the page instead of color - change pfp ps: lib used for .md is manually imported since the PR is still not merged

… and urequire

…e amount of money user sent

matijamarjanovic · 2024-12-09T15:53:25Z

To leave a quick comment on the new look and logic of the home realm:

Since there is no more HTML i have made up three themes of the home realm, since markdown is pretty restrictive these themes look similar but the difference can be made
The voting system is still used even though now there is no spectrum of values like there is in rgb. Instead, the theme with the most votes at a time is used
The number of votes is now measured by number of ugnots the realm is holding for the specific theme and this time there is no normalization, again, this is because there is a lack of a spectrum
For generating components in markdown I have used this library suggested by @leohhhn

Realm is not deployed to any network as I have already taken a couple of namespaces and don't want to keep doing that, instead I am looking to get this approved and get my original namespace :)

PS it is getting registered to the Hall of Realms

leohhhn · 2024-12-09T16:13:15Z

Hey @matijamarjanovic,

Generally you shouldn't take other people's code like this (the MDUI pkg). I know this was not your intention, but what you did was just copy paste this lib and if this PR is merged it will be your commit, effectively denying the original author their rights.

What you should do, is, either use a library that exists in master (p/moul/md was merged recently), or make a branch from the branch that contains the code you want to use, which will make your PR dependent on the original PR you branched off of.

I suggest you switch to using p/moul/md and I'll take a look. It shouldn't be too big of a change.

matijamarjanovic · 2024-12-09T16:30:27Z

Hey @matijamarjanovic,

Generally you shouldn't take other people's code like this (the MDUI pkg). I know this was not your intention, but what you did was just copy paste this lib and if this PR is merged it will be your commit, effectively denying the original author their rights.

What you should do, is, either use a library that exists in master (p/moul/md was merged recently), or make a branch from the branch that contains the code you want to use, which will make your PR dependent on the original PR you branched off of.

I suggest you switch to using p/moul/md and I'll take a look. It shouldn't be too big of a change.

I thught this might be an issue and i agree, I even credited the author in the code through a comment above the code. I'll be commiting the fix in the next hour

leohhhn

LGTM 💯

leohhhn · 2024-12-10T09:06:32Z

Just check the CI; for example, you should run make fmt in the examples folder (also see in the makefile what this command does)

examples/gno.land/r/matijamarjanovic/home/config.gno

matijamarjanovic added 2 commits October 7, 2024 04:24

Add files via upload

f37d39b

Merge branch 'gnolang:master' into master

f6bfd6f

matijamarjanovic requested review from a team as code owners October 7, 2024 02:27

matijamarjanovic requested review from ltzmaxwell and gfanton and removed request for a team October 7, 2024 02:27

github-actions bot assigned matijamarjanovic Oct 7, 2024

github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Oct 7, 2024

matijamarjanovic changed the title ~~Matija's Homepage Realm Example~~ feat: Matija's Homepage Realm Example Oct 7, 2024

Commit of my homepage.

105a11d

jefft0 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 8, 2024

matijamarjanovic and others added 2 commits October 8, 2024 16:58

Update config.gno so std.GetOrigCaller is not used anymore. Use std.P…

2a593d0

…revRealm().Addr()

Update config.gno and home.gno so std.PrevRealm() and std.CurrentReal…

cf8af82

…m() are used

matijamarjanovic changed the title ~~feat: Matija's Homepage Realm Example~~ feat: add Matija's Homepage realm to examples Oct 8, 2024

notJoon suggested changes Oct 10, 2024

View reviewed changes

examples/gno.land/r/matijamarjanovic/config/config.gno Outdated Show resolved Hide resolved

examples/gno.land/r/matijamarjanovic/config/config.gno Outdated Show resolved Hide resolved

examples/gno.land/r/matijamarjanovic/config/config.gno Outdated Show resolved Hide resolved

matijamarjanovic and others added 4 commits October 10, 2024 16:11

Fix name variables in the config file (comment on PR - hese two varia…

16529d3

…ble's names are seems ambiguous. Could you update their names? like mainAddr)

Fix error messages, add constants and print them as errors - (comment…

15e15a2

… on PR - error messages are repeated (invalid arress and unauthorized). please make them as constant.)

Fix variable names, make them more intuitive from a to newAddress (co…

ef98d67

…mment on PR - very niptick: consider change parameter name a to more concrete name.)

Merge branch 'master' into master

e7de68c

Fix name issues in config

4929361

notJoon approved these changes Oct 11, 2024

View reviewed changes

Maelkum reviewed Oct 13, 2024

View reviewed changes

Minor fixes regarding newfound comments.

dfaf8aa

matijamarjanovic added 4 commits October 14, 2024 15:59

gno fmt, update code format

840bddc

Remove strconv and use %v in Sptintf instead

15cf829

Fixed so AssertAuthorized (a public func) relies on private checkAuth…

df3a438

…orized so the logic is only in 1 place

Return to previous state

f075d6d

Merge branch 'gnolang:master' into master

d6ebeca

matijamarjanovic added 7 commits December 9, 2024 13:07

fix formatting using gno fmt

ddae776

- remove unused snake art bs

ae81d7a

- reorganize the home.gno so it doesn't use html anymore but mark down lib by @thanhgoc541 - change logic to vote for theme of the page instead of color - change pfp ps: lib used for .md is manually imported since the PR is still not merged

update test so it matches the new home realm, this time using uassert…

50607f2

… and urequire

- update the voting system so the number of votes is determined by th…

06796c7

…e amount of money user sent

adjust tests

16da68f

change the AssertAuthorized to call std.GetOrigCaller()

fa421fe

register to hall of fame

3fd4875

Merge branch 'master' into master

5cfbd0e

matijamarjanovic marked this pull request as ready for review December 9, 2024 15:54

matijamarjanovic mentioned this pull request Dec 9, 2024

feat(examples): MDUI framework #2976

Open

6 tasks

matijamarjanovic added 3 commits December 9, 2024 17:14

credit mdui author

65447a6

Merge branch 'master' of https://github.com/matijamarjanovic/gno

66bcc77

fix fmt

a87681b

matijamarjanovic added 2 commits December 9, 2024 17:53

remove the copy of mdui package, and integrate /p/moul/md

d3228f3

update test accordingly

0162f40

matijamarjanovic requested a review from leohhhn December 9, 2024 17:01

Merge branch 'master' into master

fca1fab

leohhhn approved these changes Dec 10, 2024

View reviewed changes

run make fmt examples to format for CI

c686bb0

thehowl reviewed Dec 10, 2024

View reviewed changes

examples/gno.land/r/matijamarjanovic/home/config.gno Show resolved Hide resolved

thehowl approved these changes Dec 10, 2024

View reviewed changes

Merge branch 'master' into master

b6bdf36

thehowl merged commit 4e7305b into gnolang:master Dec 10, 2024
105 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add Matija's Homepage realm to examples #2916

feat: add Matija's Homepage realm to examples #2916

matijamarjanovic commented Oct 7, 2024

notJoon left a comment

matijamarjanovic commented Oct 10, 2024 •

edited

Loading

Maelkum left a comment

matijamarjanovic commented Oct 14, 2024 •

edited

Loading

thehowl commented Oct 23, 2024

Gno2D2 commented Dec 9, 2024 •

edited

Loading

If

Then

If

Then

If

Can be checked by

matijamarjanovic commented Dec 9, 2024 •

edited

Loading

leohhhn commented Dec 9, 2024

matijamarjanovic commented Dec 9, 2024 •

edited

Loading

leohhhn left a comment

leohhhn commented Dec 10, 2024 •

edited

Loading

feat: add Matija's Homepage realm to examples #2916

feat: add Matija's Homepage realm to examples #2916

Conversation

matijamarjanovic commented Oct 7, 2024

Summary

Key Features

Tools & Technologies

Why this is valuable

notJoon left a comment

Choose a reason for hiding this comment

matijamarjanovic commented Oct 10, 2024 • edited Loading

Maelkum left a comment

Choose a reason for hiding this comment

matijamarjanovic commented Oct 14, 2024 • edited Loading

thehowl commented Oct 23, 2024

Gno2D2 commented Dec 9, 2024 • edited Loading

Automated Checks

Manual Checks

If

Then

If

Then

If

Can be checked by

matijamarjanovic commented Dec 9, 2024 • edited Loading

leohhhn commented Dec 9, 2024

matijamarjanovic commented Dec 9, 2024 • edited Loading

leohhhn left a comment

Choose a reason for hiding this comment

leohhhn commented Dec 10, 2024 • edited Loading

matijamarjanovic commented Oct 10, 2024 •

edited

Loading

matijamarjanovic commented Oct 14, 2024 •

edited

Loading

Gno2D2 commented Dec 9, 2024 •

edited

Loading

matijamarjanovic commented Dec 9, 2024 •

edited

Loading

matijamarjanovic commented Dec 9, 2024 •

edited

Loading

leohhhn commented Dec 10, 2024 •

edited

Loading