-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle untyped constant expressions in append() #1177
Merged
Merged
Commits on Sep 27, 2023
-
fix: append nil to an array was causing a panic
This is a particular case of Go append builtin where the array type is inferred from the first argument. We detect using untyped nil as argument, then we convert it to the array type prior to proceeed further. It fixes further consistency checks and value generation. Fixes gnolang#1136.
Configuration menu - View commit details
-
Copy full SHA for aabf7c2 - Browse repository at this point
Copy the full SHA aabf7c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0432faf - Browse repository at this point
Copy the full SHA 0432fafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1455aa7 - Browse repository at this point
Copy the full SHA 1455aa7View commit details
Commits on Nov 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4e8c3cf - Browse repository at this point
Copy the full SHA 4e8c3cfView commit details -
Update gnovm/pkg/gnolang/preprocess.go
Co-authored-by: Morgan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 196c6fb - Browse repository at this point
Copy the full SHA 196c6fbView commit details
Commits on Nov 30, 2023
-
fix: catch forbidden conversions of undefined nil to scalar types
This is done in ConverTo, so hopefully it works both at parsing and during execution, and for composite types. Some additional test cases have been added too.
Configuration menu - View commit details
-
Copy full SHA for 42c657e - Browse repository at this point
Copy the full SHA 42c657eView commit details
Commits on Dec 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3d08d54 - Browse repository at this point
Copy the full SHA 3d08d54View commit details
Commits on Jan 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1779b8f - Browse repository at this point
Copy the full SHA 1779b8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04614ec - Browse repository at this point
Copy the full SHA 04614ecView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.