Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests should not rely on network connections #836

Open
thehowl opened this issue May 19, 2023 · 1 comment
Open

tests should not rely on network connections #836

thehowl opened this issue May 19, 2023 · 1 comment
Labels
🌟 improvement performance improvements, refactors ...

Comments

@thehowl
Copy link
Member

thehowl commented May 19, 2023

From #829. Tests on package gnomod, but potentially also others, require having a functioning network connection. This should not be a prerequisite (both to allow offline testing, but also to not break tests should test3 go down).

@thehowl thehowl added the 🌟 improvement performance improvements, refactors ... label May 19, 2023
@moul moul added this to the 💡Someday/Maybe milestone Sep 6, 2023
@moul
Copy link
Member

moul commented Oct 9, 2023

Related with #1215.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 improvement performance improvements, refactors ...
Projects
Status: Triage
Development

No branches or pull requests

4 participants