Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grc20] Is uint64 enough to handle total_supply and balance stuff? #741

Closed
r3v4s opened this issue Apr 14, 2023 · 3 comments
Closed

[grc20] Is uint64 enough to handle total_supply and balance stuff? #741

r3v4s opened this issue Apr 14, 2023 · 3 comments
Assignees

Comments

@r3v4s
Copy link
Contributor

r3v4s commented Apr 14, 2023

I just found out that grc20 currently uses uint64 to handle balance, total supply stuff.

I know that code is demo, it is not going to release same as right now when main net launches.... but just want to ask if there is an any intend over there

@moul
Copy link
Member

moul commented Apr 14, 2023

What about switching to the new bigint?

#650 #676

@r3v4s
Copy link
Contributor Author

r3v4s commented Apr 14, 2023

What about switching to the new bigint?

#650 #676

#676 is ready for review.
After merge, I'll change data types in GRC* codes (20 will be first, 721 will be next)

@r3v4s r3v4s changed the title [grc20] Is uint64 enough to handle total_supply and balacne stuff? [grc20] Is uint64 enough to handle total_supply and balance stuff? Apr 14, 2023
@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 8, 2023
@r3v4s
Copy link
Contributor Author

r3v4s commented Jun 11, 2024

Closing for now as we are trialling the uint256 package instead.

@r3v4s r3v4s closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🌟 Wanted for Launch
Status: Done
Development

No branches or pull requests

2 participants