Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workshops: forum tutorial tests failing #1897

Open
MalekLahbib opened this issue Apr 7, 2024 · 3 comments
Open

workshops: forum tutorial tests failing #1897

MalekLahbib opened this issue Apr 7, 2024 · 3 comments
Assignees
Labels
🐞 bug Something isn't working

Comments

@MalekLahbib
Copy link
Contributor

MalekLahbib commented Apr 7, 2024

Description

@zivkovicmilos

we've tried to follow your forum tutorial, but the forum_test.gno was displaying errors each time:

Screenshot from 2024-04-07 16-44-26

So after making several tests and trying to find the problem, I realized that the "setter" functions were not modifying the forum created in the test file and then realized that these functions were called with (f Forum) instead of (f *Forum).

So can you modify your hackmd file so that it works correctly?

PS: I don't know if you added the forum example somewhere, and if you want us to do a PR to add is to the examples.

@zivkovicmilos
Copy link
Member

Hey @MalekLahbib,

Thank you for looking into this 🙏

I've pinged our DevRel @leohhhn to take a look at optimizing this tutorial and seeing where we can fit it in on the official docs / some tutorial page, so I'll keep this issue open until we resolve it

@zivkovicmilos zivkovicmilos added the 🐞 bug Something isn't working label Apr 8, 2024
@zivkovicmilos zivkovicmilos changed the title forum tutorial workshops: forum tutorial tests failing Apr 8, 2024
@leohhhn leohhhn moved this from Priority 1 to Backlog in 👥 Team: Devrels May 13, 2024
Copy link

This issue is stale because it has been open 6 months with no activity. Remove stale label or comment or this will be closed in 3 months.

@github-actions github-actions bot added the Stale label Nov 19, 2024
@leohhhn
Copy link
Contributor

leohhhn commented Nov 20, 2024

Will revisit/reuse this tutorial for the upcoming docs revamp

@github-actions github-actions bot removed the Stale label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

3 participants