Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[txtar] remove unexpected behavior in txtar tests (premines, predeploys) #1484

Closed
zivkovicmilos opened this issue Dec 22, 2023 · 1 comment
Closed
Labels
🌟 improvement performance improvements, refactors ...

Comments

@zivkovicmilos
Copy link
Member

Description

As discussed in #1471, I believe txtar tests should always start with a fresh chain, and not have initial accounts or initial deployments (in genesis). The reason for this being, txtar environments should be heavily controlled by the test maker, and not have unexpected premines and predeploys when the node starts within the test.

Instead, I propose we introduce functionality to control these features, similar to what @deelawn is doing in #1471. This way, the test maker can actually choose to premine or predeploy specific accounts or contracts. It is more explicit, and breaks away from the behavior we have lurking in the codebase of stuff happening behind the scenes without the user's knowledge (especially with chain initialization).

Looking for opinions @moul @gfanton @ajnavarro

@zivkovicmilos
Copy link
Member Author

This was resolved as part of #1471 and #1598

Thank you @deelawn and @gfanton 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 improvement performance improvements, refactors ...
Projects
Development

No branches or pull requests

1 participant