Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing test case for _get_measures #732

Open
jd opened this issue Feb 9, 2018 · 1 comment
Open

Missing test case for _get_measures #732

jd opened this issue Feb 9, 2018 · 1 comment
Labels
good first issue

Comments

@jd
Copy link
Member

jd commented Feb 9, 2018 •
edited by chungg
Loading

@chungg noted in #730 that gnocchi.storage.StorageDriver._get_measures can raise MetricDoesNotExist and AggregationDoesNotExist but there is no code path that covers this case in the tests.
@jd jd changed the title Missing test case for _get_measures Missing test case for _get_measures Feb 9, 2018
@jd jd mentioned this issue Feb 9, 2018
Merged
@chungg
Copy link
Member

chungg commented Feb 9, 2018

edited to included AggregationDoesNotExist.

it does seem like the API validation already ensures this isn't possible. so maybe the discussion is where we want this validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jd @chungg