Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for isSameImage() #10

Open
hrj opened this issue Sep 28, 2015 · 3 comments
Open

Unit tests for isSameImage() #10

hrj opened this issue Sep 28, 2015 · 3 comments
Assignees
Milestone

Comments

@hrj
Copy link
Member

hrj commented Sep 28, 2015

Since image comparison is the keystone of the testing process, we need to test the isSameImage implementation thoroughly.

Some ideas:

  • Need to create sets of similar images (some with small differences, some with larger diffs).
  • Test with and without thresholds
  • Test with same size and different size images
  • Test missing images

Lesser priority tests:

  • Test corrupted images
  • Test hue variations
  • Test transparency
@hrj hrj added this to the 0.1 milestone Sep 28, 2015
@hrj
Copy link
Member Author

hrj commented Oct 6, 2015

@atiqsayyed Thanks for PR #18

Do you want to continue adding more tests for isSameImage or would like to pick up something else?

BTW, I have committed some minor changes on master (avoids creating driver for image tests).

@atiqsayyed
Copy link
Contributor

@hrj it depends on what else is on priority...
If we're fine with having the basic tests in place then I can pick something else which may be of higher priority

@hrj
Copy link
Member Author

hrj commented Oct 6, 2015

@atiqsayyed working on image comparison tests is better for now because it is independent of other work, so there will be minimal interference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants