Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shulkerboxes.sc not working in 1.21 #392

Open
AMilli2 opened this issue Jun 21, 2024 · 3 comments
Open

shulkerboxes.sc not working in 1.21 #392

AMilli2 opened this issue Jun 21, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@AMilli2
Copy link

AMilli2 commented Jun 21, 2024

I tried using the vacuum function in version 1.21, but the items keep going to the player's inventory.

@AMilli2 AMilli2 added the bug Something isn't working label Jun 21, 2024
@manchesterjm
Copy link

manchesterjm commented Jun 21, 2024

Yep, seeing the same thing in 1.21

@manchesterjm
Copy link

any easy fix here? what line of code needs to be updated?

@samule-i
Copy link

samule-i commented Aug 11, 2024

any easy fix here? what line of code needs to be updated?

I don't think it's an "easy" fix.

1.21 has changed a lot of how nbt data works
For example, when checking the shulkerbox's name has 'vacuum' it reads shulker_tag:'display.Name on line 137

This doesn't return anything anymore, I've found that you can get the same data using shulker_tag:'components':'minecraft:custom_name', but there might be a better way to access it and I'm just not familiar enough.

This happens repeatedly through the code, any time that shulkerboxes accessed nbt data, it's almost guaranteed to have been moved in the changes.

As for which line specifically? So far, any line that uses shulker_tag probably needs looking at, as least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants