This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Set ModernWindow to set the event state equal to the child state #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jerakin
commented
Aug 18, 2019
| event.accept() | ||
| else: | ||
| self._w.close() | ||
| event.setAccepted(self._w.isHidden()) |
There was a problem hiding this comment.
isHidden seems to be the most reliable way to figure out if a window is closed or not
gmarull
approved these changes
Nov 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
If you click on the (x) button to close a window ModernWindow and the Child get different closeEvent's. This means that even of I
.ignore()the event in the Child. The ModernWindow doesn't know this and closes anyway. (This can be observed by running the mainwindow.py and pressing the (x) button and taking "No" in the dialog - it closes anyway).Describe the solution
Set the ModernWindow event to be accepted by the return value of the child's
.close()Potensial Problems
I am not sure what the need for the
eventFilteras opposed tocloseEvent, I changed ModernWindow to only use closeEvent for simplicity sake.