Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] some window rules don't work #786

Closed
perrylets opened this issue Oct 11, 2024 · 3 comments · Fixed by #798
Closed

[Bug] some window rules don't work #786

perrylets opened this issue Oct 11, 2024 · 3 comments · Fixed by #798
Labels
released type: bug Something isn't working

Comments

@perrylets
Copy link

Describe the bug

My window rule that sets some windows to floating don't apply to the Flow launcher settings and Steam windows that aren't the main one (except for the news window), the rule that ignores the window applies correctly to Steam Big Picture mode, but leaves a small gap at the bottom of the screen. This worked perfectly fine before updating to 3.4.0

Reproduction

window_rules:
  # Task Manager requires admin privileges to manage and should be ignored unless running
  # the WM as admin.
  - commands: ["ignore"]
    match:
      - window_process: { equals: "steamwebhelper" }
        window_title: { regex: ".*Big Picture.*" }

  - commands: ["set-floating"]
    match:
      - window_process: { equals: "steamwebhelper" }
        window_title: { regex: "(?!Steam).*" }

      - window_process: { equals: "Flow.Launcher" }
        window_title: { equals: "Settings" }

      - window_title: { equals: "Visual Studio Installer" }

Stack trace or error logs (if applicable)

No response

Version number

3.4.0

@perrylets perrylets added the type: bug Something isn't working label Oct 11, 2024
@github-project-automation github-project-automation bot moved this to 📬 Needs triage in glazewm Oct 11, 2024
@perrylets perrylets changed the title [Bug] some windows rule don't work [Bug] some window rules don't work Oct 12, 2024
@RiceaRaul
Copy link
Contributor

Hi @perrylets, the steam regex doesn't work because rust doesn't support lookahead negatives. I opened a thread #798 with a fix that may help you.

@github-project-automation github-project-automation bot moved this from 📬 Needs triage to ✅ Done in glazewm Oct 23, 2024
Copy link

🎉 This issue has been resolved in version 3.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@perrylets
Copy link
Author

perrylets commented Oct 28, 2024

@lars-berger The flow launcher rule still fails, when the settings are opened it remains tiled, this issue shouldn't be marked as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants