Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] NVIDIA Geforce NOW and KeePassXC should be managed #701

Closed
proJM-Coding opened this issue Aug 29, 2024 · 9 comments · Fixed by #726
Closed

[Bug] NVIDIA Geforce NOW and KeePassXC should be managed #701

proJM-Coding opened this issue Aug 29, 2024 · 9 comments · Fixed by #726
Labels
released type: bug Something isn't working

Comments

@proJM-Coding
Copy link

Describe the bug

I noticed that with KeePassXC and NVIDIA GeForce NOW they both have a problem which their window behavior isn't controlled by glazewm. Switching focus never selects these windows, these windows spawn as floating even though I have set windows to tiling. These windows show on every workspace and this was not an issue for KeePassXC before the rust rewrite (NVIDIA GeForce NOW always had this issue). I am using mostly the default config, most of my changes are hotkeys.

Reproduction

Open ether KeePassXC or NVIDIA GeForce NOW and notice how they both will spawn as floating. Move to any workspace and notice how the window is always shown in every workspace. Change focus with alt + arrow keys and notice how the focus will never land on ether window.

Stack trace or error logs (if applicable)

No response

Version number

v3.1.1

@proJM-Coding proJM-Coding added the type: bug Something isn't working label Aug 29, 2024
@github-project-automation github-project-automation bot moved this to 📬 Needs triage in glazewm Aug 29, 2024
@lars-berger
Copy link
Member

When a window is shown on all workspaces like that, it means that GlazeWM isn't managing the window

The logic for whether a window should be managed has mostly stayed the same. One slight difference is that if we fail to get the process name or class name of a window, the behavior now is that we skip managing it - perhaps this is what's happening for NVIDIA Geforce and KeePassXC

@lars-berger lars-berger changed the title [Bug] Floating windows on all workspaces [Bug] NVIDIA Geforce NOW and KeePassXC should be managed Aug 31, 2024
@proJM-Coding
Copy link
Author

That would make sense to me but I don't understand why KeePassXC is not managed after the rust rewrite. Is there some way I can check if it got the process name or class name of a window?

@Sh00Fly
Copy link

Sh00Fly commented Sep 10, 2024

I'm observing the same behavior here.
Here is what Window Spy thinks of KeePassXC window:
image

@lars-berger
Copy link
Member

I'm observing the same behavior here. Here is what Window Spy thinks of KeePassXC window: image

Hmm the window title, class, and process all look valid in that pic. Does KeePass get managed if you start GlazeWM when the KeePass window is already open?

@proJM-Coding
Copy link
Author

NVIDIA GeForce NOW does get put in the tiling layout but is still shown on all workspaces. KeePassXC still isn't managed.

Here is winspy for KeePassXC:
image

And here is winspy for NVIDIA GeForce NOW:
image

@proJM-Coding
Copy link
Author

Thanks for that, I'll test if it works once the next release is out.

Copy link

🎉 This issue has been resolved in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@proJM-Coding
Copy link
Author

KeePassXC is now managed after installing 3.3.0 but NVIDIA Geforce NOW is still not managed. This was a problem back before with the C# version though.

@Likver
Copy link

Likver commented Oct 28, 2024

i remember yesterday i opened up gfn and saw that the window was being managed (because it was following all windows rules i had for every window except for those i was ignoring in the config.yaml, and switching workspaces on the same monitor would actually hide the gfn window) but i didnt look at why did that suddenly worked, since i didnt change anything that day as far as i remember, i cant exactly remember if it was after or before updating to v3.5.0, but seeing the discord announcement time when it was posted, id say it was before, so if it was, i dont know why it suddenly managed its window

but today it stopped being managed as usual, while again, i didnt change anything before opening gfn today, so i dont really know what or why did it happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants