From 0ea13ff1923527bbc69a5fa44ce905fe2a4c593d Mon Sep 17 00:00:00 2001
From: Markus Westerlind <marwes91@gmail.com>
Date: Wed, 14 Aug 2019 23:10:18 +0200
Subject: [PATCH] perf(check): Only do one lookup/insertion on the implicit
 definition map

---
 check/src/implicits.rs | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/check/src/implicits.rs b/check/src/implicits.rs
index d33faf74f6..548c7811d6 100644
--- a/check/src/implicits.rs
+++ b/check/src/implicits.rs
@@ -231,10 +231,6 @@ impl ImplicitBindings {
         path: &[TypedIdent<Symbol, RcType>],
         typ: &RcType,
     ) {
-        if let Some(definition) = definition {
-            self.definitions.insert(definition.clone(), ());
-        }
-
         let level = Level(self.partition_insertions.len().try_into().unwrap());
 
         self.partition
@@ -770,7 +766,11 @@ impl<'a> ImplicitResolver<'a> {
         // add it again to prevent ambiguities
         if let Some(metadata) = metadata {
             if let Some(ref definition) = metadata.definition {
-                if self.implicit_bindings.definitions.contains_key(definition) {
+                if self
+                    .implicit_bindings
+                    .definitions
+                    .insert(definition.clone(), ())
+                {
                     return;
                 }
             }