Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sass-embedded is not supported on all platforms #168

Closed
jelly opened this issue Feb 9, 2024 · 3 comments
Closed

sass-embedded is not supported on all platforms #168

jelly opened this issue Feb 9, 2024 · 3 comments

Comments

@jelly
Copy link

jelly commented Feb 9, 2024

Since 3.0.0 this plugin switched to sass-embedded it now relies on binaries to be available for all platforms. We also build for s390x and aarch64 (and likely ppc64) for which sass-embedded does not distribute binaries.

Would it be possible to maybe allow for either sass or sass-embedded to be a dependency of esbuild-sass-plugin. Looking at sass-loader and vite. This seems to be something npm can support.

I'm happy to write a patch to make this happen.

@glromeo
Copy link
Owner

glromeo commented Feb 22, 2024

I am looking into trying and providing both sass as default to work on any platform and leave sass-embedded as an option
...thank you for spotting this shortcoming! It sucks indeed

@glromeo
Copy link
Owner

glromeo commented Feb 23, 2024

please let me know how it goes with v3.1.0

@glromeo glromeo closed this as completed Feb 23, 2024
@martinpitt
Copy link

@glromeo Thanks a lot! It works very well indeed, ARM builds are happy again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants