Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow compression in HPMC simulations. #1641

Closed
joaander opened this issue Oct 25, 2023 · 7 comments
Closed

Slow compression in HPMC simulations. #1641

joaander opened this issue Oct 25, 2023 · 7 comments
Labels
enhancement New feature or request hpmc HPMC component

Comments

@joaander
Copy link
Member

Description

Add a method that slowly compresses in HPMC simulations.

Proposed solution

Either implement SlowCompress or add optional arguments to QuickCompress. In either case, apply the QuickCompress algorithm to a variable box size.

Additional context

QuickCompress works extremely well, but always quenches to the chosen box size. Some simulation workflows require slow annealing. MD simulations can use BoxResize. HPMC simulations need an alternate method that accounts for particle overlaps.

@joaander joaander added the enhancement New feature or request label Oct 25, 2023
@joaander
Copy link
Member Author

@tcmoore3 you asked about this once. Would you be interested in implementing it?

@tcmoore3
Copy link
Member

I am interested, but since I don't have a research need for this at the moment I cannot commit to implementing it.

@tcmoore3
Copy link
Member

Now that I'm thinking about it, it should be fairly straightforward. Unless I'm missing something, shouldn't this consist of adding a variant to UpdaterQuickCompress and using that variant to compute the new box in UpdaterQuickCompress::getNewBox by modifying the minimum scale factor?

@joaander
Copy link
Member Author

Yes, we can replace target_box with a box that varies over time. Work on this should wait pending the outcome of #1640 where I am suggesting a new BoxVariant API.

@joaander
Copy link
Member Author

Now that #1685 is merged, we make target_box a BoxVariant in QuickCompress. @tcmoore3 do you plan to implement this? I would like to put it in the next release.

@tcmoore3
Copy link
Member

I'm not sure why GitHub didn't automatically close this when #1736 was merged, but #1736 resolves this issue.

@joaander
Copy link
Member Author

I'm not sure why GitHub didn't automatically close this when #1736 was merged, but #1736 resolves this issue.

GitHub automatically closes issues only when a pull request is merged into the default branch (trunk-patch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hpmc HPMC component
Projects
None yet
Development

No branches or pull requests

2 participants