Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent logger keyword argument name in write.GSD and write.Table #1480

Closed
tcmoore3 opened this issue Feb 3, 2023 · 0 comments · Fixed by #1482
Closed

Inconsistent logger keyword argument name in write.GSD and write.Table #1480

tcmoore3 opened this issue Feb 3, 2023 · 0 comments · Fixed by #1482
Assignees
Labels
task Something needs to be done.

Comments

@tcmoore3
Copy link
Member

tcmoore3 commented Feb 3, 2023

Description

Deprecate the use of write.GSD(..., log=log.Logger) in place of write.GSD(..., logger=log.Logger) for consistency with write.Table.

Motivation and context

Both write.GSD and write.Table accept log.Logger arguments to log simulation data. This argument is named log in the GSD writer and logger in the Table writer. For consistency and since we are providing a Logger, this argument should be named logger.

@tcmoore3 tcmoore3 added the task Something needs to be done. label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Something needs to be done.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants