Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Remove/rename wrapper around setComponentTemplate #326

Open
pzuraq opened this issue Dec 21, 2020 · 0 comments
Open

Remove/rename wrapper around setComponentTemplate #326

pzuraq opened this issue Dec 21, 2020 · 0 comments

Comments

@pzuraq
Copy link
Member

pzuraq commented Dec 21, 2020

Currently, we wrap the VM's version of setComponentTemplate with a function that calls templateFactory on the serialized template block. This means the transform can be simpler overall, and we import one fewer function in each module, saving bytes, but it does not match the implementation in Ember, which requires us to pass in the template factory. We should either remove this wrapping layer and do it in the Babel transform, or we should rename it and export it as a separate utility function that the Babel transform can target.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant