Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollView is stuck when you scroll vertically on iOS, (This is a solution) #78

Open
johnslobodan07 opened this issue Oct 3, 2022 · 1 comment

Comments

@johnslobodan07
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-swipe-gestures/index.js b/node_modules/react-native-swipe-gestures/index.js
index 38d1db5..fd94b51 100644
--- a/node_modules/react-native-swipe-gestures/index.js
+++ b/node_modules/react-native-swipe-gestures/index.js
@@ -58,8 +58,8 @@ class GestureRecognizer extends Component {
 
   _gestureIsClick(gestureState) {
     return (
-      Math.abs(gestureState.dx) < swipeConfig.gestureIsClickThreshold &&
-      Math.abs(gestureState.dy) < swipeConfig.gestureIsClickThreshold
+      Math.abs(gestureState.dx) < swipeConfig.gestureIsClickThreshold 
+      //&& Math.abs(gestureState.dy) < swipeConfig.gestureIsClickThreshold
     );
   }
 

This issue body was partially generated by patch-package.

@NoatToan
Copy link

NoatToan commented Dec 1, 2022

I found that the solution causes bad behavior on vertical scrolling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants