Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sky object #120

Open
ntessore opened this issue Jan 29, 2015 · 0 comments
Open

Update sky object #120

ntessore opened this issue Jan 29, 2015 · 0 comments

Comments

@ntessore
Copy link
Contributor

In light of #118 and our discussion, we should rework the sky foreground.

  • The background sky should only have a single constant value. I would also suggest that we rename it to a const source.
  • There should be a grad source that is a luminosity gradient over the image. With Define kernel constants also in object code #118 it can be centred on the image.

The choice of words here is deliberate: I think that we can get rid of the FOREGROUND category of objects altogether. If these sources are to be in the foreground, they should simply be placed before the first lens, like all other sources. That would make them usable if there ever was the need to lens those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant