M or M/h or M*h

[rbmetcalf]

@cgiocoli Need some help here.
The following lines in your HaloCalculator (renamed some time ago) are
not consistent with each other. It would help if the constructor were unambiguous about what m is - it should be either physical mass (preferred) or
m/h or m*h and its meaning not depend on flags in the functions.

Here is the constructor

CosmoLib/halo.cpp

Line 14 in 210528b

,double mass /// halo mass in M_sun/h TODO Carlo: Is this really M_sun/h

The comment at

CosmoLib/halo.cpp

Line 111 in 210528b

case (-1): // Munoz-Cuartas et al. 2011, as the previous but M is assumet in M/h

Is inconsistent with these lines

CosmoLib/halo.cpp

Line 108 in 210528b

logc=a*log10(m*co->gethubble())+b;

CosmoLib/halo.cpp

Line 114 in 210528b

logc=a*log10(m)+b;

[rbmetcalf]

I can make the changes if you cannot.