New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing error handling #26

Merged

glejeune merged 1 commit into glejeune:master from BridgeAR:master

Mar 18, 2018

Contributor

BridgeAR commented Mar 6, 2018

The fs calls here swallow errors and that behavior is long deprecated. This will throw from Node.js 10.x on.

It will from now on report the errors back to the error callback.

Reference: nodejs/node#18668


          Fix missing error handling

a6ea928

Contributor Author

BridgeAR commented Mar 18, 2018

glejeune merged commit bb43204 into glejeune:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet