Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This library has GPL dependency #234

Closed
ypresto opened this issue Mar 28, 2017 · 8 comments
Closed

This library has GPL dependency #234

ypresto opened this issue Mar 28, 2017 · 8 comments
Labels

Comments

@ypresto
Copy link
Contributor

ypresto commented Mar 28, 2017

This library depends on term-ansicolor.

In Gemfile:

s.add_dependency 'term-ansicolor', '>= 1.3.2'

In code:

def warn_deprecated(message)
  log_stderr Term::ANSIColor.yellow Term::ANSIColor.bold "#{program_name}: [DEPRECATED] #{message}"
end

And term-ansicolor is released under GPLv2.

It means this library should be licensed under GPL or drop dependency to term-ansicolor.
https://www.gnu.org/licenses/gpl-faq.en.html#MereAggregation

@ypresto
Copy link
Contributor Author

ypresto commented Mar 28, 2017

Someone attempted to ask to change license but it failed... See issue 24 of term-ansicolor.

@ypresto
Copy link
Contributor Author

ypresto commented Mar 28, 2017

Possible alternative licensed under MIT:
https://github.com/sickill/rainbow

@glebm
Copy link
Owner

glebm commented Mar 28, 2017

Well, ouch.

I'm accepting PRs to switch to another library, and left a comment on issue 24 of term-ansicolor.

@glebm glebm added the bug label Mar 28, 2017
@ypresto
Copy link
Contributor Author

ypresto commented Mar 29, 2017

rainbow does not have dark method used in i18n-tasks so I sent PR to add it:
ku1ik/rainbow#53

@ypresto
Copy link
Contributor Author

ypresto commented Mar 29, 2017

Also added uncolor method replacement:
ku1ik/rainbow#54

@ypresto
Copy link
Contributor Author

ypresto commented Mar 29, 2017

As license_finder, current (0d31ef4) library licenses are:

Dependencies that need approval:
activesupport, 5.0.2, MIT
ast, 2.3.0, MIT
axlsx, 2.0.1, MIT
bundler, 1.13.6, unknown
byebug, 9.0.6, "Simplified BSD"
concurrent-ruby, 1.0.5, MIT
diff-lcs, 1.3, "MIT, Artistic-2.0, GPL-2.0+"
docile, 1.1.5, MIT
easy_translate, 0.5.0, unknown
erubis, 2.7.0, MIT
highline, 1.7.8, ruby
htmlentities, 4.3.4, MIT
httparty, 0.14.0, MIT
i18n, 0.8.1, MIT
i18n-tasks, 0.9.12, MIT
json, 2.0.3, ruby
license_finder, 3.0.0, MIT
mini_portile2, 2.1.0, MIT
minitest, 5.10.1, MIT
multi_xml, 0.6.0, MIT
nokogiri, 1.7.1, MIT
parser, 2.4.0.0, MIT
powerpack, 0.1.1, MIT
rainbow, 2.2.1, MIT
rake, 12.0.0, MIT
rspec, 3.5.0, MIT
rspec-core, 3.5.4, MIT
rspec-expectations, 3.5.0, MIT
rspec-mocks, 3.5.0, MIT
rspec-support, 3.5.0, MIT
rubocop, 0.48.0, MIT
ruby-progressbar, 1.8.1, MIT
rubyzip, 1.0.0, ruby
simplecov, 0.14.1, MIT
simplecov-html, 0.10.0, MIT
terminal-table, 1.7.3, MIT
thor, 0.19.4, MIT
thread, 0.2.2, WTFPL
thread_safe, 0.3.6, "Apache 2.0"
tzinfo, 1.2.3, MIT
unicode-display_width, 1.1.3, MIT
with_env, 1.1.0, MIT
xml-simple, 1.1.5, ruby
yard, 0.9.8, MIT

(easy_translate is MIT licensed.)

LGTM..!

@glebm
Copy link
Owner

glebm commented Mar 29, 2017

Released v0.9.13!

@ypresto
Copy link
Contributor Author

ypresto commented Mar 29, 2017

Thanks, applied to our project and working fine..! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants