Skip to content

Commit

Permalink
Drop support for Ruby < 2.5
Browse files Browse the repository at this point in the history
2.3 and 2.4 are EOL
  • Loading branch information
glebm committed Dec 22, 2020
1 parent 5df0fdc commit e71a3bf
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
AllCops:
TargetRubyVersion: 2.3
TargetRubyVersion: 2.5
Exclude:
- 'tmp/**/*'
- 'vendor/bundle/**/*'
Expand Down
2 changes: 0 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ rvm:
- 2.7.0
- 2.6.5
- 2.5.7
- 2.4.9
- 2.3.8
- jruby-9.2.11.0
- rbx-4
jobs:
Expand Down
2 changes: 1 addition & 1 deletion i18n-tasks.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ TEXT
TEXT
s.homepage = 'https://github.com/glebm/i18n-tasks'
s.metadata = { 'issue_tracker' => 'https://github.com/glebm/i18n-tasks' } if s.respond_to?(:metadata=)
s.required_ruby_version = '>= 2.3', '< 4.0' if s.respond_to?(:required_ruby_version=)
s.required_ruby_version = '>= 2.5', '< 4.0' if s.respond_to?(:required_ruby_version=)

s.files = `git ls-files`.split($/)
s.files -= s.files.grep(%r{^(doc/|\.|spec/)}) + %w[CHANGES.md config/i18n-tasks.yml Gemfile]
Expand Down

3 comments on commit e71a3bf

@aleksandrs-ledovskis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have been helpful if both this and next Ruby version deprecations (happening in 0.9.37) were included in CHANGELOG

@davidwessman
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleksandrs-ledovskis
That makes sense, can you submit a PR?

@aleksandrs-ledovskis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

#420

Please sign in to comment.