Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add initial version of scout cli #1

Merged
merged 26 commits into from
Feb 27, 2024
Merged

feat: add initial version of scout cli #1

merged 26 commits into from
Feb 27, 2024

Conversation

pmig
Copy link
Member

@pmig pmig commented Feb 22, 2024

The initial version can be tested if it is cloned next to packages repository and the corresponding (dev) scripts can be found in the package.json file. e.g. scout:package:cyclops or scount:index.

@pmig pmig requested a review from kosmoz February 22, 2024 15:43
kosmoz
kosmoz requested changes Feb 23, 2024
View reviewed changes
Copy link
Member

@kosmoz kosmoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I have some comments, I think the general setup seems sound.

In addition to the comments: I don't understand how the built files in dist/ work. Running node ./dist/index.js does nothing.

package.json Show resolved Hide resolved
bin/dev.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be TS?

bin/run.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be TS?

tsconfig.json Show resolved Hide resolved
src/types/artifacthub/jsonschema.ts Outdated Show resolved Hide resolved
src/commands/index/index.ts Outdated Show resolved Hide resolved
src/services/index.ts Outdated Show resolved Hide resolved
src/commands/package/index.ts Show resolved Hide resolved
src/commands/package/index.ts Outdated Show resolved Hide resolved
src/services/index.ts Outdated Show resolved Hide resolved
@pmig
chore: upgrade dependencies, add package-lock.json
67962e1 
Signed-off-by: Philip Miglinci <[email protected]>
@pmig
refactor: rename schema file, improve interface extension
02f0565 
Signed-off-by: Philip Miglinci <[email protected]>
@pmig
test: improve testdata and exclude test files from tsconfig
53a3d6e 
Signed-off-by: Philip Miglinci <[email protected]>
@pmig
refactor: rename parse method
2b31055 
Signed-off-by: Philip Miglinci <[email protected]>
@pmig
refactor: declare attributes in constructor
06d3635 
Signed-off-by: Philip Miglinci <[email protected]>
@pmig
refactor: add "no-multiple-empty-lines" eslint rule
d8e8efa 
Signed-off-by: Philip Miglinci <[email protected]>
@pmig
refactor: remove not needed initialization
361f7d8 
Signed-off-by: Philip Miglinci <[email protected]>
@pmig
chore: add noImplicitAny, noImplicitReturns, noImplicitOverride to ts…
348aaf4 
…config

Signed-off-by: Philip Miglinci <[email protected]>
@pmig
refactor: rename methods, remove unneded copy
b06e43a 
Signed-off-by: Philip Miglinci <[email protected]>
@pmig
refactor: use path.join for file system path manipulation
3e53274 
Signed-off-by: Philip Miglinci <[email protected]>
@pmig
refactor: use spec.ts instead of test.ts suffix for tests
c22cad2 
Signed-off-by: Philip Miglinci <[email protected]>
@pmig
refactor: move type generation to scripts, clean npm scripts
60f6995 
Signed-off-by: Philip Miglinci <[email protected]>
@pmig
docs: clean README.md
cfae664 
Signed-off-by: Philip Miglinci <[email protected]>
@pmig
refactor: make commands more expressive by using update:
4209882 
Signed-off-by: Philip Miglinci <[email protected]>
@pmig
fix: fail if manifest version missmatch detected
a3e1190 
Signed-off-by: Philip Miglinci <[email protected]>
@pmig
refactor: use await, exclude test files from tsconfig
12216f8 
Signed-off-by: Philip Miglinci <[email protected]>
@pmig
feat: calculate next build number previous max build number
c0f09cf 
Signed-off-by: Philip Miglinci <[email protected]>
@pmig
chore: fix no-return-await eslint rule
e143f1d 
https://eslint.org/docs/latest/rules/no-return-await

Signed-off-by: Philip Miglinci <[email protected]>
@pmig
refactor: split old services file into manifest and package
958be60 
Signed-off-by: Philip Miglinci <[email protected]>
@pmig pmig requested a review from kosmoz February 27, 2024 10:09
@kosmoz
chore: prepare package.json for publishing
01f320e 
Signed-off-by: Jakob Steiner <[email protected]>

chore: change package.json to more conventional structure

Signed-off-by: Jakob Steiner <[email protected]>
@kosmoz
ci: add initial workflows
e7f7c2d 
Signed-off-by: Jakob Steiner <[email protected]>
@kosmoz
docs: update readme
dcc0c80 
Signed-off-by: Jakob Steiner <[email protected]>
@kosmoz kosmoz merged commit 102ed80 into main Feb 27, 2024
3 checks passed
This was referenced Feb 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosmoz kosmoz Awaiting requested review from kosmoz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmig @kosmoz