fix(cli): version prefix v now is now optional #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosmoz
requested changes
May 6, 2024
There was a problem hiding this comment.
Thanks @sumeshmurali!
This looks good, but I think it would be a little cleaner to use strings.HasPrefix instead. Could you please make this change?
pmig
force-pushed
the
sumeshmurali/cli-version-prefix-fix
branch
from
72ce02e to
64d371c
Compare
Made the changes. Can you check now? |
- the program automatically adds a 'v' prefix if the user inputs it without one
kosmoz
force-pushed
the
sumeshmurali/cli-version-prefix-fix
branch
from
c03fe29 to
093086f
Compare
kosmoz
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #463
📑 Description
The PR make changes to
-v/--versionin the glasskube cli. Previously it requires the user to add "v" prefix to the version. With the PR the user will be able to pass exact version and the code internally adds a "v" prefix.✅ Checks
ℹ Additional Information