From a6a285dcee9e0fe618286d3dfbfab98c957dd9c7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gast=C3=B3n=20Kleiman?= <gkleiman@lyft.com>
Date: Wed, 8 Jul 2020 12:32:32 -0700
Subject: [PATCH] Add extra fields to CDS cluster proto to check memory usage
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Gastón Kleiman <gkleiman@lyft.com>
---
 api/envoy/config/cluster/v3/cluster.proto              | 10 ++++++++++
 api/envoy/config/cluster/v4alpha/cluster.proto         | 10 ++++++++++
 .../envoy/config/cluster/v3/cluster.proto              | 10 ++++++++++
 .../envoy/config/cluster/v4alpha/cluster.proto         | 10 ++++++++++
 4 files changed, 40 insertions(+)

diff --git a/api/envoy/config/cluster/v3/cluster.proto b/api/envoy/config/cluster/v3/cluster.proto
index 6123bd59c14e..44dfd8e16292 100644
--- a/api/envoy/config/cluster/v3/cluster.proto
+++ b/api/envoy/config/cluster/v3/cluster.proto
@@ -327,6 +327,7 @@ message Cluster {
   }
 
   // Specific configuration for the LeastRequest load balancing policy.
+  // [#next-free-field: 7]
   message LeastRequestLbConfig {
     option (udpa.annotations.versioning).previous_message_type =
         "envoy.api.v2.Cluster.LeastRequestLbConfig";
@@ -359,6 +360,15 @@ message Cluster {
     // .. note::
     //   This setting only takes effect if all host weights are not equal.
     core.v3.RuntimeDouble active_request_bias = 2;
+
+    // Add new fields to see whether the per-cluster memory footprint increases
+    core.v3.RuntimeDouble foo = 3;
+
+    bool foo1 = 4;
+
+    double foo2 = 5;
+
+    double foo3 = 6;
   }
 
   // Specific configuration for the :ref:`RingHash<arch_overview_load_balancing_types_ring_hash>`
diff --git a/api/envoy/config/cluster/v4alpha/cluster.proto b/api/envoy/config/cluster/v4alpha/cluster.proto
index 6c1302d28941..c11f24f83f2a 100644
--- a/api/envoy/config/cluster/v4alpha/cluster.proto
+++ b/api/envoy/config/cluster/v4alpha/cluster.proto
@@ -330,6 +330,7 @@ message Cluster {
   }
 
   // Specific configuration for the LeastRequest load balancing policy.
+  // [#next-free-field: 7]
   message LeastRequestLbConfig {
     option (udpa.annotations.versioning).previous_message_type =
         "envoy.config.cluster.v3.Cluster.LeastRequestLbConfig";
@@ -362,6 +363,15 @@ message Cluster {
     // .. note::
     //   This setting only takes effect if all host weights are not equal.
     core.v4alpha.RuntimeDouble active_request_bias = 2;
+
+    // Add new fields to see whether the per-cluster memory footprint increases
+    core.v4alpha.RuntimeDouble foo = 3;
+
+    bool foo1 = 4;
+
+    double foo2 = 5;
+
+    double foo3 = 6;
   }
 
   // Specific configuration for the :ref:`RingHash<arch_overview_load_balancing_types_ring_hash>`
diff --git a/generated_api_shadow/envoy/config/cluster/v3/cluster.proto b/generated_api_shadow/envoy/config/cluster/v3/cluster.proto
index cf6b9cb652b3..4a849f19ea0a 100644
--- a/generated_api_shadow/envoy/config/cluster/v3/cluster.proto
+++ b/generated_api_shadow/envoy/config/cluster/v3/cluster.proto
@@ -327,6 +327,7 @@ message Cluster {
   }
 
   // Specific configuration for the LeastRequest load balancing policy.
+  // [#next-free-field: 7]
   message LeastRequestLbConfig {
     option (udpa.annotations.versioning).previous_message_type =
         "envoy.api.v2.Cluster.LeastRequestLbConfig";
@@ -359,6 +360,15 @@ message Cluster {
     // .. note::
     //   This setting only takes effect if all host weights are not equal.
     core.v3.RuntimeDouble active_request_bias = 2;
+
+    // Add new fields to see whether the per-cluster memory footprint increases
+    core.v3.RuntimeDouble foo = 3;
+
+    bool foo1 = 4;
+
+    double foo2 = 5;
+
+    double foo3 = 6;
   }
 
   // Specific configuration for the :ref:`RingHash<arch_overview_load_balancing_types_ring_hash>`
diff --git a/generated_api_shadow/envoy/config/cluster/v4alpha/cluster.proto b/generated_api_shadow/envoy/config/cluster/v4alpha/cluster.proto
index 6c1302d28941..c11f24f83f2a 100644
--- a/generated_api_shadow/envoy/config/cluster/v4alpha/cluster.proto
+++ b/generated_api_shadow/envoy/config/cluster/v4alpha/cluster.proto
@@ -330,6 +330,7 @@ message Cluster {
   }
 
   // Specific configuration for the LeastRequest load balancing policy.
+  // [#next-free-field: 7]
   message LeastRequestLbConfig {
     option (udpa.annotations.versioning).previous_message_type =
         "envoy.config.cluster.v3.Cluster.LeastRequestLbConfig";
@@ -362,6 +363,15 @@ message Cluster {
     // .. note::
     //   This setting only takes effect if all host weights are not equal.
     core.v4alpha.RuntimeDouble active_request_bias = 2;
+
+    // Add new fields to see whether the per-cluster memory footprint increases
+    core.v4alpha.RuntimeDouble foo = 3;
+
+    bool foo1 = 4;
+
+    double foo2 = 5;
+
+    double foo3 = 6;
   }
 
   // Specific configuration for the :ref:`RingHash<arch_overview_load_balancing_types_ring_hash>`