Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macros for detected ball radius and lookup grid size should be parameters #5

Open
geronm opened this issue Jul 7, 2016 · 0 comments

Comments

@geronm
Copy link
Collaborator

geronm commented Jul 7, 2016

In gelsight_groundtruth_gen.cpp (and likely soon in gelsight_depth_driver) there are macros declared for the expected detected ball size:

#define BALL_RADIUS_GUESS 45  // radius of detected ball. TODO: Make this a CL argument
#define BALL_RADIUS_GUESS_MARGIN (BALL_RADIUS_GUESS + 20)  // margin of error on ball radius, for HoughCircle
#define SNAPSHOT_WIDTH (2*BALL_RADIUS_GUESS_MARGIN)`

, and for the grid size of the lookup table:

#define REF_PT_ROWS 4  // grid resolution of final lookup table (how many lookup locations there are) TODO: CL argument
#define REF_PT_COLS 3
#define REF_GET_IMROW(ptrow, imrows) ( ((1+(ptrow)) * (imrows)) / (1+REF_PT_ROWS) )
#define REF_GET_IMCOL(ptcol, imcols) ( ((1+(ptcol)) * (imcols)) / (1+REF_PT_COLS) )

These should be moved into A) command line arguments in groundtruth_gen and B) parameters automatically read from the groundtruth output by depth_driver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant