Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing env keys and optional chaning in process.env causing unusual errors #24

Open
1 of 5 tasks
Nabhag8848 opened this issue Dec 18, 2023 · 2 comments
Open
1 of 5 tasks
Labels
bug Something isn't working

Comments

@Nabhag8848
Copy link

Nabhag8848 commented Dec 18, 2023

Description

  • As there is current addtion of slack integration, env keys ( just keys not value ) related to slack are missing, causing application with errors when running whole application npm run dev . Following keys are missing in .env.example.
SLACK_CLIENT_ID=
SLACK_CLIENT_SECRET=
SLACK_SIGNING_SECRET=
SLACK_SOCKET_TOKEN=
SLACK_APP_ID=

  • Didn't started stable as the redirect destination of /docs isn't defined. for fixing this we need to define a default port (ie: 8080 ) to start docs and add flag --port <number> for npm run docs
--- other env keys
DOCS_URL=`http://localhost:8080` (for local)
  • There are places where env variables are accessed using optional chaning which never will be optional, causing usual crash.

Screenshots

  • Slack key error:
ss
  • Missing docs key
ss 1

Additional information

  • Willingly need to contribute, As this are unrelated issue but small, do you need me to make different PRs or bundle up in same with different commits would be fine ?
  • is the idea about docs giving default port Looks good to you ? or am i missing something in future plans ?
@Nabhag8848 Nabhag8848 added the bug Something isn't working label Dec 18, 2023
@Nabhag8848
Copy link
Author

Hey @nevo-david just few fixes i observed while setting up. waiting for acknowledge for PR, with my questions mentioned.

@nevo-david
Copy link
Contributor

Hi @Nabhag8848! :)
Thank you so much for this,
the library was not yet released to the public,
I am still working on updating the documentation and variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants