Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run workspace integration tests nightly against main on core-dev #9597

Closed
jenting opened this issue Apr 27, 2022 · 3 comments · Fixed by #9602
Closed

Run workspace integration tests nightly against main on core-dev #9597

jenting opened this issue Apr 27, 2022 · 3 comments · Fixed by #9602
Assignees

Comments

@jenting
Copy link
Contributor

jenting commented Apr 27, 2022

Is your feature request related to a problem? Please describe

Run integration tests nightly against main for workspace components to make sure the latest main branch does not break the quality.

Describe the behaviour you'd like

Run integration tests nightly against main for workspace components by werft job running on core-dev environment, after the job finish, send a slack notification to the team workspace slack channel.

Describe alternatives you've considered

We could consider running integration per PR if the code change is related to workspace team components.

Additional context

@jenting
Copy link
Contributor Author

jenting commented Apr 28, 2022

There is no werft deployed/installed in the preview environment, we can't run the integration test job which is deploying/running by the werft. That is, now we could only run the nightly integration test on the core-dev environment.

Besides that, sending the Slack notification to the workspace team slack channel might pollute the channel and I see the IDE team post the integration test result to channel #ide-jobs, I think we could create a new channel #workspace-jobs rather than using the existing #t_workspace, WDYT?

cc @kylos101

@kylos101
Copy link
Contributor

core-dev is going away at some point, to be replaced by Hertzner.

I believe when core-dev is gone, that main's preview environment should be generated by Hertzner. Can you ask Platform team what the plan is, for the main branch's preview environment? I hope it is Hertzner, but good to confirm.

#workspace-jobs is a good idea. 👍 We were talking about doing something similar for Front messages recently.

@jenting
Copy link
Contributor Author

jenting commented May 2, 2022

core-dev is going away at some point, to be replaced by Hertzner.

I believe when core-dev is gone, that main's preview environment should be generated by Hertzner. Can you ask Platform team what the plan is, for the main branch's preview environment? I hope it is Hertzner, but good to confirm.

#workspace-jobs is a good idea. 👍 We were talking about doing something similar for Front messages recently.

After discussing with Kyle, now the default development cluster is core-dev. Once the platform team changes the default development to preview-environment, we should be able to run an integration test on preview-environment without any code change (if possible).

@jenting jenting changed the title Run integration tests nightly against main for workspace components Run integration tests nightly against main for workspace components on core-dev May 9, 2022
@jenting jenting changed the title Run integration tests nightly against main for workspace components on core-dev Run workspace integration tests nightly against main on core-dev May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants