Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO limits are not applied #9341

Closed
Furisto opened this issue Apr 14, 2022 · 2 comments · Fixed by #9404
Closed

IO limits are not applied #9341

Furisto opened this issue Apr 14, 2022 · 2 comments · Fixed by #9404
Assignees
Labels
aspect: performance anything related to performance component: ws-daemon priority: highest (user impact) Directly user impacting team: workspace Issue belongs to the Workspace team

Comments

@Furisto
Copy link
Member

Furisto commented Apr 14, 2022

Bug description

We are observing that IO limits are currently not applied to workpspaces. The config map for ws-daemon contains the correct configuration but no attempt seems to be made to enforce the limits via io.max.

Steps to reproduce

  • Open workspace
  • SSH to the node the workspace is running on
  • find /sys/fs/cgroup/kubepods -name io.max | xargs cat
  • -> this should show devices that are limited, but currently nothing is there

The plugins can be found here.
The io limit plugin is here
The plugin is called here

Workspace affected

No response

Expected behavior

IO limits should be applied

Example repository

No response

Anything else?

No response

@kylos101 kylos101 moved this to Scheduled in 🌌 Workspace Team Apr 14, 2022
@kylos101 kylos101 added team: workspace Issue belongs to the Workspace team aspect: performance anything related to performance component: ws-daemon labels Apr 14, 2022
@kylos101 kylos101 moved this from Scheduled to In Progress in 🌌 Workspace Team Apr 15, 2022
@kylos101 kylos101 removed the status in 🌌 Workspace Team Apr 15, 2022
@kylos101 kylos101 moved this to Scheduled in 🌌 Workspace Team Apr 15, 2022
@kylos101
Copy link
Contributor

Hey @Furisto , may we ask for your help with this issue when you return to work? Also, you may find this internal grafana comparison intersting.

@stephenavocado
Copy link

This issue is still affecting me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect: performance anything related to performance component: ws-daemon priority: highest (user impact) Directly user impacting team: workspace Issue belongs to the Workspace team
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants