Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users that prebuilds have been paused for inactive projects #9232

Closed
gtsiolis opened this issue Apr 11, 2022 · 3 comments · Fixed by #14081
Closed

Warn users that prebuilds have been paused for inactive projects #9232

gtsiolis opened this issue Apr 11, 2022 · 3 comments · Fixed by #14081
Assignees
Labels
feature: prebuilds meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: feature request New feature or request type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 11, 2022

Problem to solve

In #9219 (Cc @jankeromnes) we're introducing pausing prebuilds for inactive projects. While this automatic pause helps in being efficient in consumption, etc, it could be confusing for users when opening project prebuilds to see an empty list of prebuilds without any useful information or call-to-action.

Cc @easyCZ because #8911

Proposal

Show a warning alert when prebuilds have been paused for a project including the reasoning and a call-to-action to open a new workpace, trigger a prebuild, and enable prebuilds again.

The project card can reuse the same latest prebuild status as now with the label No recent prebuilds.

Project prebuilds Project card
Prebuilds CARD-AFTER

Front logo Front conversations

@gtsiolis gtsiolis added type: feature request New feature or request feature: prebuilds type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Apr 11, 2022
@jankeromnes
Copy link
Contributor

jankeromnes commented Apr 11, 2022

Thanks @gtsiolis! I really like your proposed UX (banner, wording) and I agree that we should implement this.

it could be confusing for users when opening project prebuilds to see an empty list of prebuilds without any useful information or call-to-action.

Just on a side note, the intent in #9219 is not to have an empty Prebuilds list when the Project is inactive, but to have a list of cancelled Prebuilds (one for every push you make to your repository), and when you open these cancelled Prebuilds, they should show:

(/) Cancelled
    Project is inactive. Please start a new workspace for this project to re-enable prebuilds.

@gtsiolis
Copy link
Contributor Author

... the intent in #9219 is not to have an empty Prebuilds list when the Project is inactive, but to have a list of cancelled Prebuilds ...

question: Ah, I see! Isn't this more confusing? What is the value of keeping a list of non-existing prebuilds or potentially to-be-created prebuilds in a list, especially since we also garbage collect existing prebuilds?

@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jul 10, 2022
@gtsiolis gtsiolis added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Jul 11, 2022
@geropl geropl moved this to Scheduled in 🍎 WebApp Team Sep 19, 2022
@AlexTugarev AlexTugarev self-assigned this Oct 21, 2022
@AlexTugarev AlexTugarev moved this from Scheduled to In Progress in 🍎 WebApp Team Oct 21, 2022
Repository owner moved this from In Progress to In Validation in 🍎 WebApp Team Oct 28, 2022
@AlexTugarev AlexTugarev moved this from In Validation to Done in 🍎 WebApp Team Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: prebuilds meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: feature request New feature or request type: improvement Improves an existing feature or existing code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants