Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StartWorkspace] Make sure ensureWorkspaceAuth is called #9145

Closed
AlexTugarev opened this issue Apr 6, 2022 · 1 comment · Fixed by #9488
Closed

[StartWorkspace] Make sure ensureWorkspaceAuth is called #9145

AlexTugarev opened this issue Apr 6, 2022 · 1 comment · Fixed by #9488
Assignees
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@AlexTugarev
Copy link
Member

Today I reopened two workspaces from yesterday which did not make into the IDE, but the workspace pod actually were there and reported readiness. After investigating with @geropl and @akosyakov, we came to the conclusion that the owner token might not have been set during the workspace startup flow, because all of the supervisor request were returned with code 403.

Having a look at the StartWorkspace.tsx reveals that we might need to reiterate on the process ensureWorkspaceAuth is actually called. Cases to consider:

  • workspace will be re-opened in a tab in background and browser window get blurred
  • a timed-out workspace tab remained in background
@AlexTugarev AlexTugarev added the team: webapp Issue belongs to the WebApp team label Apr 6, 2022
@geropl geropl added the type: bug Something isn't working label Apr 6, 2022
@geropl geropl moved this to Scheduled in 🍎 WebApp Team Apr 6, 2022
@geropl
Copy link
Member

geropl commented Apr 6, 2022

Scheduled it.

@geropl geropl self-assigned this Apr 22, 2022
@geropl geropl moved this from Scheduled to In Progress in 🍎 WebApp Team Apr 22, 2022
Repository owner moved this from In Progress to Done in 🍎 WebApp Team Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
Archived in project
2 participants