Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[license] Make the domain field optional #8410

Closed
corneliusludmann opened this issue Feb 23, 2022 · 1 comment · Fixed by #8996
Closed

[license] Make the domain field optional #8410

corneliusludmann opened this issue Feb 23, 2022 · 1 comment · Fixed by #8996
Labels
team: delivery Issue belongs to the self-hosted team type: improvement Improves an existing feature or existing code
Milestone
release/2022.03

Comments

@corneliusludmann
Copy link
Contributor

corneliusludmann commented Feb 23, 2022 •
edited
Loading

Currently, we have a domain field in the license and we check that the domain matches the Gitpod domain. @metcalfc already mentioned that he would like to not ask for a domain when a customer approaches and with Replicated, we have at least some control about the distribution of the license as we see the number of installations in the vendor portal (I guess as long as it's not an air-gap installation).

I would propose to implement at least the Replicated license like this:

  • Make the domain field in the license optional.
  • When there is a domain given, the domain needs to match. Otherwise, the license is invalid.
  • When there is no domain, this license is valid for all domains (no restriction).

With this implementation, we are quite flexible as we can set the domain field in the license or not (sales decision) and can change this at any time without code changes.
@corneliusludmann corneliusludmann added team: delivery Issue belongs to the self-hosted team type: improvement Improves an existing feature or existing code labels Feb 23, 2022
@mrsimonemms mrsimonemms mentioned this issue Mar 10, 2022
Closed
@mrsimonemms mrsimonemms moved this from 🧊Backlog to 📓Scheduled in 🚚 Security, Infrastructure, and Delivery Team (SID) Mar 15, 2022
@mrsimonemms mrsimonemms mentioned this issue Mar 15, 2022
Closed
@mrsimonemms mrsimonemms added this to the release/2022.03 milestone Mar 15, 2022
@mrsimonemms mrsimonemms moved this from 📓Scheduled to ⚒In Progress in 🚚 Security, Infrastructure, and Delivery Team (SID) Mar 17, 2022
@mrsimonemms mrsimonemms mentioned this issue Mar 17, 2022
Closed
@mrsimonemms
Copy link
Contributor

Blocked by #8872

Repository owner moved this from ⚒In Progress to ✨Done in 🚚 Security, Infrastructure, and Delivery Team (SID) Mar 29, 2022
@mrsimonemms mrsimonemms reopened this Mar 29, 2022
Repository owner moved this from ✨Done to 📓Scheduled in 🚚 Security, Infrastructure, and Delivery Team (SID) Mar 29, 2022
@mrsimonemms mrsimonemms mentioned this issue Mar 29, 2022
Merged
Repository owner moved this from 📓Scheduled to ✨Done in 🚚 Security, Infrastructure, and Delivery Team (SID) Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team: delivery Issue belongs to the self-hosted team type: improvement Improves an existing feature or existing code
Projects
No open projects
🚚 Security, Infrastructure, and Delivery Team (SID)
Archived in project
Milestone
release/2022.03
Development

Successfully merging a pull request may close this issue.

[install]: document installing via kots gitpod-io/gitpod
2 participants
@mrsimonemms @corneliusludmann