Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspaces created via browser opened from Gateway go to VS Code, not the splash page. #8409

Closed
AnnaPrints opened this issue Feb 23, 2022 · 2 comments
Labels
editor: jetbrains meta: stale This issue/PR is stale and will be closed soon team: IDE type: bug Something isn't working

Comments

@AnnaPrints
Copy link

Bug description

There are some scenarios of using Gateway+GitPod which can confuse users.
When user create the first workspace via Dashboard in a browser, default preferences are:
Browser Editor: VS Code, Desktop Editor: None

Steps to reproduce

Steps:

  1. Launch Gateway, connect GitPod plugin
  2. Click on “Connect to GitPod” option
  3. Click on “Connect in Browser”
  4. Connect GitHub/GitLab/Bitbucket
  5. Go to Dashboard and create a new workspace
  6. Try to connect it

See the result: https://drive.google.com/file/d/1wOFuhtiBLMfs930iNl7SMka3W-ZuA5kv/view?usp=sharing
What helps in this situation: to change Desktop Editor from None to a JetBrains IDE and create a new workspace with these settings.
But I don’t really think that users would guess what to do.
I think we should handle such situations and add some tips or change the flow.

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

@akosyakov akosyakov added editor: jetbrains type: bug Something isn't working labels Feb 23, 2022
@akosyakov akosyakov moved this to Scheduled in 🚀 IDE Team Feb 23, 2022
@loujaybee loujaybee changed the title JB Gateway: Join flow is broken if a user created the first workspace via browser Workspaces created first via browser opened from JetBrains Gateway go straight to VS Code, and not the splash page. Mar 3, 2022
@loujaybee
Copy link
Member

Hey @AnnaPrints! Thanks a lot for the feedback!

Yeah, the complication here is that workspaces are created based on preferences and the IDE / backend is baked into the workspace on start (at least, currently). JetBrains gateway is (currently) just a list of those workspaces, and so it will respect your user preferences... however you are right, if you're coming from gateway you quite likely want a JetBrains IDE, and not VS Code in the browser. A couple of solutions on our side:

  1. Provide IDE settings that allow a user to open their workspace with an ad-hoc IDE from within the JetBrains Gateway, something similar to: (Open workspace in ad-hoc (per-workspace) editor or IDE #8573)
  2. Add an "indicator" into the Gateway about what IDE the current workspace preference is set to, and allow the user to directly override / update their preferences from within JetBrains (figure 1).
  3. Not a fix, but an additional nice-to-have, would be a prominent link to your Gitpod preferences to update the preferred / default IDE directly, possibly from within the existing cogs menu (figure 2).
Figure 1 Figure 2
image image

Relates to: #6874

@loujaybee loujaybee changed the title Workspaces created first via browser opened from JetBrains Gateway go straight to VS Code, and not the splash page. Workspaces created via browser opened from Gateway go to VS Code, not the splash page. Mar 3, 2022
@loujaybee loujaybee removed this from 🚀 IDE Team Apr 6, 2022
@stale
Copy link

stale bot commented Jun 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jun 11, 2022
@stale stale bot closed this as completed Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor: jetbrains meta: stale This issue/PR is stale and will be closed soon team: IDE type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants