Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[installer] Don't set default workspace template when no workspace template is given #8221

Closed
corneliusludmann opened this issue Feb 15, 2022 · 0 comments · Fixed by #8288
Closed

[installer] Don't set default workspace template when no workspace template is given #8221

corneliusludmann opened this issue Feb 15, 2022 · 0 comments · Fixed by #8288
Assignees
@corneliusludmann
Labels
component: install Terraform installation scripts, helm charts, installer images team: delivery Issue belongs to the self-hosted team
Milestone
release/2022.02

Comments

@corneliusludmann
Copy link
Contributor

The installer renders a default workspace template when no workspace template is given. However, the default behavior should be that no workspace template is rendered in this case.

Here is a possible fix: 84abaa8
@corneliusludmann corneliusludmann added component: install Terraform installation scripts, helm charts, installer images team: delivery Issue belongs to the self-hosted team labels Feb 15, 2022
@corneliusludmann corneliusludmann added this to the release/2022.02 milestone Feb 15, 2022
@corneliusludmann corneliusludmann mentioned this issue Feb 15, 2022
Closed
@corneliusludmann corneliusludmann self-assigned this Feb 17, 2022
@corneliusludmann corneliusludmann moved this from 📓Scheduled to ⚒In Progress in 🚚 Security, Infrastructure, and Delivery Team (SID) Feb 17, 2022
@corneliusludmann corneliusludmann mentioned this issue Feb 17, 2022
Merged
@corneliusludmann corneliusludmann moved this from ⚒In Progress to 🕶In Review / Measuring in 🚚 Security, Infrastructure, and Delivery Team (SID) Feb 17, 2022
Repository owner moved this from 🕶In Review / Measuring to ✨Done in 🚚 Security, Infrastructure, and Delivery Team (SID) Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corneliusludmann corneliusludmann

Labels
component: install Terraform installation scripts, helm charts, installer images team: delivery Issue belongs to the self-hosted team
Projects
No open projects
🚚 Security, Infrastructure, and Delivery Team (SID)
Archived in project
Milestone
release/2022.02
Development

Successfully merging a pull request may close this issue.

[installer] Remove default workspace template gitpod-io/gitpod
1 participant
@corneliusludmann