Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable prebuilds for the default branch when adding a project for a GitLab or Bitbucket repository #7424

Closed
gtsiolis opened this issue Jan 3, 2022 · 2 comments

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Jan 3, 2022

Problem to solve

When adding a GitLab or Bitbucket (#7422) project, a webhook is being added. Prebuilds are by default enabled for the default branch for GitHub repositories. However, prebuilds are not enabled for the default branch until you manually trigger a prebuild using the prefixed URL. See relevant docs[1][2] for GitLab and Bitbucket repositories.

🍊 🍊 🍊 🍊

See relevant comment in #7031 (comment):

Eventually we will most probably need to separate project addition and project configuration steps so that these can be done separastely. 💭

Proposal

To maintain a similar behavior within the product, we could consider enabling prebuilds when adding a repository as proejct without requiring triggering manully the first prebuild.

@AlexTugarev
Copy link
Member

Prebuilds are by default enabled for the default branch for GitHub repositories. However, prebuilds are not enabled for the default branch until you manually trigger a prebuild using the prefixed URL.

Quickly checked with the behavior of #7422, and I need to disagree on that. There seems to be no limitation on branches once the webhook events are registered and a config can be fetched from the repository, it starts to prebuild, see ...

Screen Shot 2022-01-04 at 12 48 50

@jldec
Copy link
Contributor

jldec commented Jan 9, 2022

Closing as non-reproducible. Please file a new issue with repro steps if you believe this is still a problem. Thanks.

@jldec jldec closed this as completed Jan 9, 2022
@jldec jldec moved this to Done in 🍎 WebApp Team Jan 9, 2022
@jldec jldec removed this from 🍎 WebApp Team Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants