Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: containerd runtime dir validation doesn't error #7205

Closed
mrsimonemms opened this issue Dec 13, 2021 · 0 comments · Fixed by #7206
Closed

[installer]: containerd runtime dir validation doesn't error #7205

mrsimonemms opened this issue Dec 13, 2021 · 0 comments · Fixed by #7206
Assignees
Labels
component: install Terraform installation scripts, helm charts, installer images team: delivery Issue belongs to the self-hosted team

Comments

@mrsimonemms
Copy link
Contributor

Bug description

If the containerd runtime dir is invalid, it doesn't actually error. It returns:

Field 'Config.Workspace.Runtime.ContainerDRuntimeDir' must start with '/'{
  "valid": true
}

The exit code is also 0

Check if this is in this one section or (more likely) a mistake in the whole config validation

Steps to reproduce

Remove the / at the start of workspace.runtime.containerdRuntimeDir and run installer validate config -c config.yaml

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

@mrsimonemms mrsimonemms added component: install Terraform installation scripts, helm charts, installer images team: delivery Issue belongs to the self-hosted team labels Dec 13, 2021
@mrsimonemms mrsimonemms self-assigned this Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: install Terraform installation scripts, helm charts, installer images team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant