Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gp cli] tasks support #7016

Closed
akosyakov opened this issue Dec 2, 2021 · 10 comments · Fixed by #8890
Closed

[gp cli] tasks support #7016

akosyakov opened this issue Dec 2, 2021 · 10 comments · Fixed by #8890
Assignees

Comments

@akosyakov
Copy link
Member

akosyakov commented Dec 2, 2021

Gitpod CLI should provide following commands to access tasks:

  • gp task list to list workspace tasks and their state
  • go task attach <id> to attach to a workspace task by an id

In order to attach we should use supervisor terminal service similar how it is done here but always with resizable and interactive session.

@axonasif
Copy link
Member

axonasif commented Dec 3, 2021

gp task attach to attach to a workspace task by an id

So this will be something like tmux I assume.
For that case I have a suggestion, I think it would be better to have a separate UI for the gitpod tasks, more like how the Remote Explorer works on Gitpod.

@akosyakov
Copy link
Member Author

akosyakov commented Dec 3, 2021

For that case I have a suggestion, I think it would be better to have a separate UI for the gitpod tasks, more like how the Remote Explorer works on Gitpod.

It is for terminal users via SSH and for IDEs there we don't provide deep integration yet, i.e. JetBrains products. Generally whatever we have in UI should be reflected in Gitpod CLI as well.

In VS Code we already have UI, Gitpod tasks are automatically opened in terminals on workspace startup.

@axonasif
Copy link
Member

axonasif commented Dec 3, 2021

It is for terminal users via SSH and for IDEs there we don't provide deep integration yet, i.e. JetBrains products. Generally whatever we have in UI should be reflected in Gitpod CLI as well.

I agree, I like to do most of my tasks from cli when possible.

In VS Code we already have UI, Gitpod tasks are automatically opened in terminals on workspace startup.

Here I was thinking about an UI for the detached background gitpod command tasks in the web version of Gitpod. But if course, cli should be there too.

@akosyakov
Copy link
Member Author

Please don't work on it. This issue is for a candidate.

@axonasif
Copy link
Member

axonasif commented Jan 3, 2022

@akosyakov I think it would be nice if the tasks subcommand had a restart/re-run task feature. Someone had asked about this in Discord. And I personally would find this feature useful too.

@akosyakov
Copy link
Member Author

@axonasif yeah, i remember had same urge sometimes. How would it work? Rerun in the same terminal? Start a new terminal?

@axonasif
Copy link
Member

axonasif commented Jan 3, 2022

@axonasif yeah, i remember had same urge sometimes. How would it work? Rerun in the same terminal? Start a new terminal?

Maybe a flag to specify the behavior? Run it on the caller terminal by default. Similar to gp preview and gp preview --external

@akosyakov
Copy link
Member Author

Oh, I mean I'm not even sure what should be default behaviour :)

@axonasif
Copy link
Member

axonasif commented Jan 6, 2022

I'm not either, I was trying to compare it with such an existing implementation of another gp subcommand 🙂

@akosyakov
Copy link
Member Author

@axonasif Could you create a separate issue about restarting a task please?

@andreafalzetti andreafalzetti self-assigned this Mar 14, 2022
@loujaybee loujaybee moved this from In Progress to Awaiting Deployment in 🚀 IDE Team Mar 29, 2022
@akosyakov akosyakov moved this from Awaiting Deployment to Done in 🚀 IDE Team Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants