Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify button labels on desktop IDE open page #6769

Closed
corneliusludmann opened this issue Nov 18, 2021 · 2 comments · Fixed by #6847
Closed

Simplify button labels on desktop IDE open page #6769

corneliusludmann opened this issue Nov 18, 2021 · 2 comments · Fixed by #6847

Comments

@corneliusludmann
Copy link
Contributor

suggestion: Although I appreciate the accuracy here, I still think this could be simplified as mentioned in #6270 (comment) but do not want to go back and forth. I'd like to suggest once more going with something like Open in XYZ but I'll leave this to you to decide.

thought: Also, happy to discuss this in a new follow up issue or #6602. Maybe updating the design here to be less verbose or using different elements could help facilitate more verbose options like Open in VS Code Insiders on Desktop. Cc @loujaybee 🏓

In this case it would become Open in VS Code Insiders while the secondary option would be 🅰️ Open in Browser or 🅱️ Open in Gitpod. See also #6270 (comment).

BEFORE AFTER 🅰️ AFTER 🅱️
Screenshot 2021-11-18 at 1 16 17 AM (2) Screenshot 2021-11-18 at 1 18 17 AM (2) Screenshot 2021-11-18 at 1 16 35 AM (2)

Originally posted by @gtsiolis in #6671 (comment)

@loujaybee
Copy link
Member

Thanks for raising / ensuring the feedback here got actioned @corneliusludmann 🙏

Given this seems like a minor UI tweak, let's add it to the groundwork. I do agree that the fundamental fix will come as part of #6602, but I'd be happy to make some temporary usability improvements in the short term 🙏 Since I think some overall UX revisions should be made here I'm not overly opinionated here on A vs B etc until it comes to moving the feature to GA.

Q: Is there a reason to keep the "insiders" copytext? In my opinion, since insiders is almost a "version" I would argue it's not necessary on the call to action here? (regardless of what the user has chosen).

If we are trying to bring clarity to the user, I'd argue that there should be a way to go from this page back to user preferences. ie. underneath the buttons we include copytext such as: These IDE options are based on [your user preferences] 🤔 . But that's somewhat out-of-scope of this issue (unless we want to add it in).

@corneliusludmann
Copy link
Contributor Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants