Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prebuilds in the storage-bucket's region #6650

Open
meysholdt opened this issue Nov 10, 2021 · 10 comments
Open

Run prebuilds in the storage-bucket's region #6650

meysholdt opened this issue Nov 10, 2021 · 10 comments
Labels
aspect: cost efficiency component: server feature: prebuilds meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@meysholdt
Copy link
Member

Running a prebuild in the same geographical region of the storage bucket to which the prebuild will be uploaded saves us costs in two places:

  • for all prebuilds, the compute egress costs from uploading the completed prebuild to its bucket.
  • for incremental prebuilds, the storage egress of downloading a prebuild with the intention of updating it.

proposed solution: ws-manager-bridge/server should be aware of the geographical region of the prebuild's storage bucket and route the prebuild to a workspace cluster in the same region.

While we may not have capacity to fix this immediately it would be great to have this on the radar.

Related:

@jldec jldec added the team: webapp Issue belongs to the WebApp team label Nov 10, 2021
@jldec jldec changed the title Run prebuilds in the sorage-bucket's region Run prebuilds in the storage-bucket's region Nov 10, 2021
@jankeromnes
Copy link
Contributor

jankeromnes commented Nov 19, 2021

This sounds like a sensible and really good idea. 👍

(Unfortunately, it does not solve the egress due to popular prebuilds getting consumed in all regions -- for example, our starter templates typically have one prebuild that gets opened in many thousands of workspaces in all regions -- if a popular prebuild is stored in a single region, then all other regions will constantly transfer the same prebuild multiple times across oceans)

@jldec jldec moved this to In Groundwork in 🍎 WebApp Team Nov 21, 2021
@JanKoehnlein
Copy link
Contributor

We're a bit swamped at the moment. Moving this to our backlog to bring it up later

@stale
Copy link

stale bot commented Apr 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Apr 2, 2022
@shaal
Copy link
Contributor

shaal commented Apr 4, 2022

If this issue becomes stale, will it be difficult to remember/find this feature-request in the future?

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Apr 4, 2022
@axonasif axonasif added the meta: never-stale This issue can never become stale label Apr 4, 2022
@jankeromnes
Copy link
Contributor

I think we should raise the priority of this issue, because:

  • We see a sharp uptake in Prebuilds, some of them with Incremental Prebuilds enabled
  • Many projects with Incremental Prebuilds enabled do this:
  1. Start new prebuild in US
  2. Download old prebuild (base) from the EU bucket ($$$)
  3. Build the new increment in US
  4. Upload the new snapshot back to the EU bucket ($$$)

... repeated on every single push to such a repository (and some projects have a very high push-rate).

Also, is team WebApp the correct owner for this?

Cc @geropl

@geropl
Copy link
Member

geropl commented May 9, 2022

Ah, didn't look long enough to find this one, but created a fresh one: #9872

@jankeromnes Could you please replace the new issue with this one? And place in on top ot the "scheduled" column? 🙏

@csweichel
Copy link
Contributor

csweichel commented May 19, 2022

Before this can work we need to solve #10134 - or make OTS region aware

@AlexTugarev
Copy link
Member

Thanks for the sharing this!

@jldec, I think this issue here is not actionable at the moment. Let's pull out of scheduled, please!

@csweichel
Copy link
Contributor

@AlexTugarev one path forward would be to make OTS region aware (i.e. introduce something like eu.gitpod.io or the likes) and use that to name the OTS. This sits directly within webapps space.

@jldec
Copy link
Contributor

jldec commented Jul 4, 2022

Removed from scheduled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect: cost efficiency component: server feature: prebuilds meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
Status: No status
Development

No branches or pull requests

9 participants