Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the heartbeat Jetbrains's plugin #6513

Closed
akosyakov opened this issue Nov 2, 2021 · 2 comments · Fixed by #6603
Closed

Clean up the heartbeat Jetbrains's plugin #6513

akosyakov opened this issue Nov 2, 2021 · 2 comments · Fixed by #6603

Comments

@akosyakov
Copy link
Member

akosyakov commented Nov 2, 2021

It should use the supervisor info endpoint instead of env vars to get information about workspace.

@loujaybee
Copy link
Member

loujaybee commented Nov 3, 2021

@akosyakov Since we've got it tracked in the GA epic, let's drop from Groundwork for now, and we can move in when we finish private + open beta 🙏

@corneliusludmann
Copy link
Contributor

If for some reason we were able to fetch the status but for a moment aren't able, we will send a heartbeat(wasClosed=true) reducing the timeout to a few minutes.

For that reason I would argue it would be better to handle the exception in the HeartbeatService, retrying and being careful about setting the this.status only after successful execution.

#6551 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants