Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark canceled prebuilds as canceled instead of failed #6153

Closed
gtsiolis opened this issue Oct 11, 2021 · 2 comments · Fixed by #5865
Closed

Mark canceled prebuilds as canceled instead of failed #6153

gtsiolis opened this issue Oct 11, 2021 · 2 comments · Fixed by #5865
Assignees
Labels
component: dashboard feature: prebuilds feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

Problem to solve

Follow up from #5865 (comment):

@gtsiolis: This is most probably out of the scope of these changes but when canceling a prebuild from the project configurator, the prebuild status on the left side of the configurator falls back to READY. Could we introduce a CANCELED status and use this as a status here? Pasting below an early draft featuring the CANCELED status.

Cross-posting from #5865 (comment):

@jankeromnes Yes, if the prebuild.state actually becomes aborted (what we want to achieve in this PR), then we could display aborted as CANCELED.

@gtsiolis gtsiolis added component: dashboard feature: prebuilds type: improvement Improves an existing feature or existing code feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. team: webapp Issue belongs to the WebApp team labels Oct 11, 2021
@jankeromnes
Copy link
Contributor

/schedule

@jankeromnes
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: prebuilds feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants