bogus http status code for payload too large error

[akosyakov]

Bug description

I'm hitting the payload too large error for UI state, but the server does not return a proper error code, but internal server error:

We should fix the error code and increase allowed payload size of UI state. The proper status code is 413: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/413#:~:text=The%20HTTP%20413%20Payload%20Too,a%20Retry%2DAfter%20header%20field.

Steps to reproduce

See above.

Expected behavior

No response

Example repository

No response

Anything else?

No response

[csweichel]

/schedule

[aledbf]

I'm hitting the payload too large error for UI state,

@akosyakov how I can trigger this error?

[akosyakov]

You should be able to reduce content limit here to reproduce:

gitpod/components/server/src/code-sync/code-sync-service.ts

Lines 214 to 216 in 6f15a43

	router.post('/v1/resource/:resource', bodyParser.text({
	limit: config?.contentLimit || defaultContentLimit
	}), async (req, res) => {

@jeanp413 pointed out that we return 500 here:

gitpod/components/server/src/server.ts

Lines 211 to 213 in ae0698e

	if (!this.isAnsweredRequest(req, response)) {
	response.status(500).send({ error: msg });
	}

Maybe it is a reason. VS Code frontend expects to see error codes as they returned by code-sync endpoint: https://github.com/microsoft/vscode/blob/ee1655a82ebdfd38bf8792088a6602c69f7bbd94/src/vs/platform/userDataSync/common/userDataSyncStoreService.ts#L476-L512 We should not convert them to 500 anywhere.